Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not remove table top border with thead and bottom border with tfoot at page break #1457

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

MurakamiShinyu
Copy link
Member

When a table with border-collapse: collapse style is split across pages, the top border of the table should not be removed if the table has thead and the bottom border should not be removed if the table has tfoot.

CSS Table Module Level 3 §6.2. Repeating headers across pages says:

When the header rows are being repeated, user agents must leave room and if needed render the table top border. The same applies for footer rows and the table bottom border.

… tfoot at page break

When a table with `border-collapse: collapse` style is split across pages, the top border of the table should not be removed if the table has thead and the bottom border should not be removed if the table has tfoot.
Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vivliostyle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 4:54pm

@MurakamiShinyu MurakamiShinyu merged commit e8d35b5 into master Feb 28, 2025
5 checks passed
@MurakamiShinyu MurakamiShinyu deleted the fix/table-border-break branch February 28, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant