Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Wilma CSS for Better Responsiveness #4061

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

milospp
Copy link
Contributor

@milospp milospp commented Feb 28, 2025

VIVO GitHub issue

What does this pull request do?

Created breakpoints for smaller screen, so that smaller devices can

What's new?

Mobile optimised design(up to 320px width)
Avoided horizontal scroll

How should this be tested?

Open every page and test by resizing up to around 400px in width (Mobile device toolbar can be used in Google Chrome to simulate phone display or ViewPort resizer extension)

Additional Notes:

Here is the video example

  • The Left window is VIVO with old Wilma theme
  • The middle window is a new, updated Wilma theme
  • The right window is Tenderfoot theme (just for comparison)

Video Example
https://youtu.be/9B0_cevrEeE

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. HTML, CSS, JavaScript

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milospp please check my comment

@@ -23,6 +23,7 @@ VIVO wilma theme: screen styles
@charset "UTF-8";

@import url("reset.css");
@import url("grid.css");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milospp do we need this line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants