-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Bootstrap and updated CSS for Wilma theme to make it responsive #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milospp bootstrap-5.3.2 directory is duplicated: webapp/bootstrap-5.3.2 and webaoo/js/bootstrap-5.3.2. Can you please check whether there is some specific reason for this or this is just a mistake?
It was a mistake; I have now removed it. Currently, we have two folders inside the 'webapp' directory: 'bootstrap-5.3.2' and 'bootstrap.' 'Bootstrap (v3)' was utilized in 'tenderfood' and 'nemo' themes, so I had to retain it in the base folder until we removed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milospp thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milospp thanks
…sponsive (vivo-project#429)" This reverts commit 8a07a74.
Revert "Added Bootstrap and updated CSS for Wilma theme to make it responsive (#429)"
Added Bootstrap and updated CSS for Wilma theme to make it responsive (vivo-project#429) * Updated wilma to bootstrap 5 * Moved bootstrap to webapp folder, changed property tabs to use bootstrap * Fixed property group tabs * Bugfix: multiple dom object with same id, individual tabs * Removed duplicate bootstrap 5.3.2 * Removed unused js code in propertGroupControls * Reimplemented tab state persistence after refresh feature * Removed unnecessary code
Added Bootstrap and updated CSS for Wilma theme to make it responsive (vivo-project#429) * Updated wilma to bootstrap 5 * Moved bootstrap to webapp folder, changed property tabs to use bootstrap * Fixed property group tabs * Bugfix: multiple dom object with same id, individual tabs * Removed duplicate bootstrap 5.3.2 * Removed unused js code in propertGroupControls * Reimplemented tab state persistence after refresh feature * Removed unnecessary code
GitHub issue 3910
GitHub PR VIVO 3909
What does this pull request do?
Added bootstrap (only grid style) CSS and modified Wilma theme to leverage its responsive design feature and enhance the overall layout.
What's new?
Added bootstrap v5
Refactored nav tabs in Person, Org Unit page to use bootstrap component instead of jQuery
Refactored files locations
How should this be tested?
Open every page and test by resizing up to around 400px in width (Mobile device toolbar can be used in google chrome to simulate phone display)
Additional Notes:
Here is the video example
https://youtu.be/9B0_cevrEeE