-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep Unreported Records For Python Grade Calculation #132
Conversation
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@AlexanderTyan - it looks like you'll need to update the Python tests scripts, because now there's more records in the historical data than it expected! |
@vkoves i updated the test output csv according to the newly changed processing + updated expected answers in tests to match what's in there. the updated [edit: grammar] |
This is the old |
@AlexanderTyan - So I did find one issue, it looks like this change breaks the historical graphs, I think because now they are getting empty data 😭
I think this can be fixed by making each graph filter out empty data - do you feel comfortable giving that a try, would you like me to try and fix it, or would you like to pair up on it next Chi Hack Night? |
@vkoves yeah, let's pair up next ChiHackNight! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, awesome work!
Description
Change/rerun data preprocessing to keep unreporting records.
Relates to issue #129, because we need non-reporting data in the CSV to calculate reporting grades
Testing Instructions
Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist: