Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 add city retrofit reports #133

Merged
merged 7 commits into from
Nov 23, 2024
Merged

70 add city retrofit reports #133

merged 7 commits into from
Nov 23, 2024

Conversation

vaidehia
Copy link
Collaborator

@vaidehia vaidehia commented Oct 23, 2024

Description

Added Retrofit Reports as supplementary documents based on the 10 use cases in the [Retrofit Report Use Cases] (https://www.chicago.gov/city/en/sites/retrofit-chicago2/home/participant-achievments/past-participants.html#case-studies). 8 of the Use cases were added into building-custom-info, 2 of them do not have existing buildingIDs in electrify-chicago database.

  • 901 W Taylor St - UIC Science and Engineering
  • 445 N Wells St - Urban Innovations Building

Fixes # 70

Testing Instructions

Tested through local deployment and checking that the buildingID was updated with Retrofit Report and that it opened in new tab when clicked.

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ n/a] I have commented my code, particularly in hard-to-understand areas
  • [ n/a] I have added tests that prove my fix is effective or that my feature works
  • [ n/a] New and existing unit tests pass locally with my changes

@vaidehia vaidehia self-assigned this Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit 8f1f4e3
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/674243a817e7a600081d8d07
😎 Deploy Preview https://deploy-preview-133--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vaidehia vaidehia assigned vkoves and unassigned vaidehia Oct 23, 2024
@vaidehia vaidehia requested a review from vkoves October 23, 2024 01:46
@@ -19,7 +19,7 @@
"dependencies": {
"csv-parse": "^5.3.6",
"d3": "^7.9.0",
"gridsome": "^0.7.0",
"gridsome": "^0.7.23",
Copy link
Owner

@vkoves vkoves Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaidehia - did you mean to upgrade the Gridsome version? (it's fine if yes, just surprised to see this)

We use Yarn, not NPM, so we didn't need this file

// !! placed this building below into the UChicago section
// //Mansueto Library at UChicago
// '252064' : {links: [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete these commented blocks?

@vkoves
Copy link
Owner

vkoves commented Oct 26, 2024

@vaidehia - I deleted the extra package.json that got generated from running npm install (that's my fault for the mix-up) but there's a few linting issues, could you fix those up? Running yarn lint-fix locally should tackle some of it

I also wonder if we should make a list of all the buildings with retrofit reports somewhere


// TODO: Figure out a way to get metaInfo working without any
// https://github.com/xerebede/gridsome-starter-typescript/issues/37
@Component<any>({

Check warning

Code scanning / ESLint

Disallow the `any` type Warning

Unexpected any. Specify a different type.

Copilot Autofix AI 3 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

})
export default class ChicagoRetrofitParticipants extends Vue {
/** Set by Gridsome to results of GraphQL query */
readonly $static: any;

Check warning

Code scanning / ESLint

Disallow the `any` type Warning

Unexpected any. Specify a different type.

Copilot Autofix AI 3 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

export default class ChicagoRetrofitParticipants extends Vue {
/** Set by Gridsome to results of GraphQL query */
readonly $static: any;
readonly $context: any;

Check warning

Code scanning / ESLint

Disallow the `any` type Warning

Unexpected any. Specify a different type.

Copilot Autofix AI 3 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Copy link
Owner

@vkoves vkoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work! I confirmed all the links are right and that the new links section looks good on desktop and mobile. I also tacked on an extra retrofit Chicago case studies page so we can view all of them at once.

@vkoves vkoves merged commit 2b7c8cd into main Nov 23, 2024
7 checks passed
@vkoves vkoves deleted the 70-add-city-retrofit-reports branch November 23, 2024 21:29
@vkoves vkoves mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants