-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
70 add city retrofit reports #133
Conversation
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -19,7 +19,7 @@ | |||
"dependencies": { | |||
"csv-parse": "^5.3.6", | |||
"d3": "^7.9.0", | |||
"gridsome": "^0.7.0", | |||
"gridsome": "^0.7.23", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaidehia - did you mean to upgrade the Gridsome version? (it's fine if yes, just surprised to see this)
We use Yarn, not NPM, so we didn't need this file
|
||
// !! placed this building below into the UChicago section | ||
// //Mansueto Library at UChicago | ||
// '252064' : {links: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you delete these commented blocks?
@vaidehia - I deleted the extra I also wonder if we should make a list of all the buildings with retrofit reports somewhere |
|
||
// TODO: Figure out a way to get metaInfo working without any | ||
// https://github.com/xerebede/gridsome-starter-typescript/issues/37 | ||
@Component<any>({ |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
Copilot Autofix AI 3 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
}) | ||
export default class ChicagoRetrofitParticipants extends Vue { | ||
/** Set by Gridsome to results of GraphQL query */ | ||
readonly $static: any; |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
Copilot Autofix AI 3 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
export default class ChicagoRetrofitParticipants extends Vue { | ||
/** Set by Gridsome to results of GraphQL query */ | ||
readonly $static: any; | ||
readonly $context: any; |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
Copilot Autofix AI 3 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, awesome work! I confirmed all the links are right and that the new links section looks good on desktop and mobile. I also tacked on an extra retrofit Chicago case studies page so we can view all of them at once.
Description
Added Retrofit Reports as supplementary documents based on the 10 use cases in the [Retrofit Report Use Cases] (https://www.chicago.gov/city/en/sites/retrofit-chicago2/home/participant-achievments/past-participants.html#case-studies). 8 of the Use cases were added into building-custom-info, 2 of them do not have existing buildingIDs in electrify-chicago database.
Fixes # 70
Testing Instructions
Tested through local deployment and checking that the buildingID was updated with Retrofit Report and that it opened in new tab when clicked.
Checklist: