Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Years Reported Graph #137

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix Years Reported Graph #137

merged 2 commits into from
Nov 20, 2024

Conversation

vkoves
Copy link
Owner

@vkoves vkoves commented Nov 20, 2024

Description

Now that we have full historic data, our reporting tile needs to account for that, rather than looking for data gaps.

Before After
Screenshot from 2024-11-19 20-21-05 Screenshot from 2024-11-19 20-20-53

Fixes #136

Testing Instructions

Spot checked against the data portal with:

  • Crown Hall (didn't report in 2018 and 2022)
  • Merch Mart (reported in all years, which we previously showed incorrectly)
  • Water Tower (reported all years)

An interesting note - Chase Tower doesn't have GHG intensity data but did report, and has electricity and natural gas figures. The city has marked them as reporting, but we don't have the full data:

Screenshot from 2024-11-19 20-25-51

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Now that we have full historic data, it needs to account for that
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit 69d5575
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/673d4c8c1b9e2c0008074842
😎 Deploy Preview https://deploy-preview-137--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vkoves
Copy link
Owner Author

vkoves commented Nov 20, 2024

It seems there's over 1,5000 records where they there's electric and gas use, but no GHG intensity 🙃

Screenshot from 2024-11-19 20-32-28

@vkoves
Copy link
Owner Author

vkoves commented Nov 20, 2024

There are also buildings that are marked as "Submitted" but have no values at all, so GHG Intensity may not be the right check, but I'm not sure what is. Electric use?

@vkoves
Copy link
Owner Author

vkoves commented Nov 20, 2024

Simple and sound and fixes an urgent issue, so merging this in

@vkoves vkoves merged commit 726d074 into main Nov 20, 2024
7 checks passed
@vkoves vkoves deleted the fix-years-reported branch November 20, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Years Reported Graphic No Longer Accurate
1 participant