Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove removed lib/svg library #1557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gagath
Copy link
Contributor

@gagath gagath commented Feb 25, 2021

This library is not present anymore but is still mentionned in some
places.

This library is not present anymore but is still mentionned in some
places.
@Harvie
Copy link
Collaborator

Harvie commented Feb 25, 2021

If you are into this stuff, i would prefer some code cleanup of STL and PLY imports.

Namely to strip STL import down to single file. Similar to how PLY is imported.
And to extend PLY import binary format (currently only ASCII is supported).

@gagath
Copy link
Contributor Author

gagath commented Feb 25, 2021

If you are into this stuff, i would prefer some code cleanup of STL and PLY imports.
Namely to strip STL import down to single file. Similar to how PLY is imported.
And to extend PLY import binary format (currently only ASCII is supported).

Nice to know, I will try to do this in another pull-request. In the meanwhile please let me know if anything from this one is incorrect. A little bit of cleanup will help new contributors to not get lost in the used dependencies (now using svgelements instead of lib/svg/).

@tatarize
Copy link
Contributor

Yeah. svgelements is a descendant of svg.path from way back but with actual svg parsing rather than just basic path. During the last update after I solved a lot more edge cases and it was stable and had vectorization to make the loading much faster, I removed the last bits of svg.path since it hadn't been used since the initial switch to svgelements . I only checked that no code anywhere referenced it, not that there wasn't any documentation etc.

@tatarize
Copy link
Contributor

The older name was svg_elements though really it was svg.elements but the dot was non-pythonic and thus dropped. Version "1.4.2" could included with pypi since I briefly went back through and ported the stuff over to python 2 for the last round of upgrade, and included that in the pypi manifest etc. I only included it directly since it seemed the way things were being done.

@Harvie
Copy link
Collaborator

Harvie commented Feb 26, 2021

This library is not present anymore but is still mentionned in some

BTW you are quite thorough... do you use some automatic tool to find unnecessary libraries in the project?

@gagath
Copy link
Contributor Author

gagath commented Mar 1, 2021

This library is not present anymore but is still mentionned in some

BTW you are quite thorough... do you use some automatic tool to find unnecessary libraries in the project?

Mhm, not really. I have found some issues using Lintian, but not this one. Packaging for Debian requires careful reading of the COPYRIGHT* files. I found that this part was not required anymore so I took the opportunity to write this small contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants