-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove removed lib/svg library #1557
base: master
Are you sure you want to change the base?
Conversation
This library is not present anymore but is still mentionned in some places.
If you are into this stuff, i would prefer some code cleanup of STL and PLY imports. Namely to strip STL import down to single file. Similar to how PLY is imported. |
Nice to know, I will try to do this in another pull-request. In the meanwhile please let me know if anything from this one is incorrect. A little bit of cleanup will help new contributors to not get lost in the used dependencies (now using svgelements instead of lib/svg/). |
Yeah. |
The older name was svg_elements though really it was svg.elements but the dot was non-pythonic and thus dropped. Version "1.4.2" could included with pypi since I briefly went back through and ported the stuff over to python 2 for the last round of upgrade, and included that in the pypi manifest etc. I only included it directly since it seemed the way things were being done. |
BTW you are quite thorough... do you use some automatic tool to find unnecessary libraries in the project? |
Mhm, not really. I have found some issues using Lintian, but not this one. Packaging for Debian requires careful reading of the |
This library is not present anymore but is still mentionned in some
places.