Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Orient method (solve - overdetermined) provided sub optimal reorientation, furthermore only rotation and translation are implemented, no options for x/y scaling.
#700 (geometric error compensation)
I've created a new method for the task. It's a primitive and naive evolutionary-like algorithm to get more optimal rotation, translation and scaling parameters for Orient. Not too sophisticated but provides great results using only 250-400 iterations (well_subsecond).
I got more precise positions than using the old solver method (even by the time I have not implemented scaling yet).
I needed scaling badly, so now I get great drill positions after Orient.
[Changing Orient stuff (e.g. active marker slider) reexecutes the algorithm (just like it did before), 400 more iterations are executed, thus slightly improves parameters and gets lower errors. Rather a feature than bug.]