Add progress bars #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad Arama <[email protected]>
Use Black Code style and pylint checker
Update log_anonymizer.py (linting and cleanup)
vladarama
requested changes
Jan 31, 2024
log_anonymizer.py
Outdated
|
|
||
| with open(input_file_path, 'r') as input_file, open(output_file_path, 'w') as output_file: | ||
| for line in input_file: | ||
| line_count = count_lines(filename=file_name) |
There was a problem hiding this comment.
Suggested change
| line_count = count_lines(filename=file_name) | |
| line_count = count_lines(file_path=input_file_path) |
I am running into issues on this line, python cannot find the file.
I think we need to provide the file path instead. This should make it work.
There was a problem hiding this comment.
This is a rebase deal. Yes, your patch suggestions are valid! :)
log_anonymizer.py
Outdated
| @@ -279,48 +357,81 @@ def randomize_numbers(number, is_ip_address = False): | |||
| return random.randint(lower_bound, upper_bound) | |||
|
|
|||
|
|
|||
| def count_lines(filename:str)->int: | |||
There was a problem hiding this comment.
Suggested change
| def count_lines(filename:str)->int: | |
| def count_lines(file_path:str)->int: |
log_anonymizer.py
Outdated
| @@ -279,48 +357,81 @@ def randomize_numbers(number, is_ip_address = False): | |||
| return random.randint(lower_bound, upper_bound) | |||
|
|
|||
|
|
|||
| def count_lines(filename:str)->int: | |||
| c = 0 | |||
| with open(filename) as file: | |||
There was a problem hiding this comment.
Suggested change
| with open(filename) as file: | |
| with open(file_path) as file: |
|
Trying the "resolve confilicts" button. Maybe it broke everything? |
Signed-off-by: MatthewKhouzam <[email protected]>
MatthewKhouzam
force-pushed
the
progress
branch
from
b9be5a9 to
bd3aaa1
Compare
|
I think it's done? |
Update count_lines
MatthewKhouzam
force-pushed
the
progress
branch
from
bee8df7 to
e94806e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed after #1