manager: replace stod by boost spirit parsing #399
Conversation
|
You can use the traditional C function [1] https://en.cppreference.com/w/c/string/byte/strtof |
|
Ok thank you goth. Also, If i throw an exception on the test errno == ERANGE, I systematically get one error (my example make a read of many values). It worked if I preset errno to 0 before the call to strtod. Is that the way to do it ? |
|
Le jeu. 22 août 24, rtrepos a écrit :
But the idea also was to be sure to have the same behavior when with
use the parallelization or not. In one case we would rely on boost
spirit, on the other on the strtod. Do you think it is the case ?
Usually yes. The C standard ensures the behaviour of this function.
|
Using cvle, the reading of double from char* can lead to error when value is very low. (as mentionned here https://stackoverflow.com/questions/48086830/stdstod-throws-out-of-range-error-for-a-string-that-should-be-valid) This error does not occur with the C function strtod.
|
Ok thank you, I stoped the CI/CD checks (that were still waiting for ressources) and I close this pull request and I push new commits on master and master2.1. |
Using cvle, the reading of double from char* can lead to error when value is very low. (as mentionned here https://stackoverflow.com/questions/48086830/stdstod-throws-out-of-range-error-for-a-string-that-should-be-valid) We prefer using the boost spirit parsing as in the SaxParser code.