Fix fa_version_unsupported_reason and more #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Duan <[email protected]>
waltforme
changed the title
waltforme
force-pushed
the
fa2-unsupported
branch
from
e29340b to
5e2e2cd
Compare
Signed-off-by: Jun Duan <[email protected]>
waltforme
force-pushed
the
fa2-unsupported
branch
from
5e2e2cd to
d71349b
Compare
|
Superseded by #48 (sorry I didn't see your PR before making mine) |
No problem. I will ask for a coffee for this if some day we meet offline (just kidding). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there are some bugs in
vllm_flash_attn/flash_attn_interface.py. This PR tries to fix them.