[GPTQ] Change actorder default to "static" #1425
Open
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-dellabetta
previously approved these changes
May 12, 2025
|
nice! |
|
@kylesayrs quick question from my side. Since the old default was None, do we risk defaulting to an incorrect value for older recipes that don't include it? Especially for ones that specified it in the quantization scheme? |
|
brian-dellabetta
previously approved these changes
May 16, 2025
rahul-tuli
previously approved these changes
May 16, 2025
kylesayrs
added a commit
that referenced
this pull request
May 19, 2025
## Purpose ## * Make actorder option more intuitive for users * Enable easier adjustment of actorder default #1425 * This change is conceptually intuitive because activation ordering is a concept that only applies to the GPTQ algorithm (the only algorithm for which quantization group order matters) ## Changes ## * Add `actorder` argument to `GPTQModifier` * Override `resolve_quantization_config` method to resolve config groups with `actorder` argument * (Misc) rearrange method order to match the typical order in which they are called in the modifier lifecycle ## Testing ## * Ran llama w4a16 example to completion Signed-off-by: Kyle Sayers <[email protected]>
kylesayrs
dismissed stale reviews from rahul-tuli and brian-dellabetta
The base branch was changed.
Signed-off-by: Kyle Sayers <[email protected]>
kylesayrs
force-pushed
the
kylesayrs/gptq-actorder-default
branch
from
8cf408e to
8b9f795
Compare
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
kylesayrs
force-pushed
the
kylesayrs/gptq-actorder-default
branch
from
8b9f795 to
f6a0e25
Compare
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
kylesayrs
added a commit
that referenced
this pull request
May 22, 2025
## Purpose ## * Fix false assumption that `actorder` field is of enum type * Despite the fact that actorder passes through a [field_validator](https://github.com/neuralmagic/compressed-tensors/blob/main/src/compressed_tensors/quantization/quant_args.py#L200), `QuantizationArgs` has the [use_enum_values](https://github.com/neuralmagic/compressed-tensors/blob/main/src/compressed_tensors/quantization/quant_args.py#L128) configuration set, meaning that enum values are converted to strings. * This was done in relation to [this fix](neuralmagic/sparseml#2327) * Remove conflict with recipes which manually specify activation ordering by using a sentinel value ## Follow ups ## * #1425 ## Testing ## * Ran llama3 example with manually specified `actorder=group` --------- Signed-off-by: Kyle Sayers <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
brian-dellabetta
previously approved these changes
May 22, 2025
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
brian-dellabetta
previously approved these changes
May 29, 2025
rahul-tuli
previously approved these changes
May 30, 2025
|
Waiting for next weekly to run before merging |
kylesayrs
dismissed stale reviews from rahul-tuli and brian-dellabetta
The base branch was changed.
brian-dellabetta
previously approved these changes
May 30, 2025
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Prerequisites
Changes
Testing