-
Notifications
You must be signed in to change notification settings - Fork 155
fix skipif check on tests involving gated HF models #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Brian Dellabetta <[email protected]>
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @brian-dellabetta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue where tracing tests for community user PRs were incorrectly skipped due to an overly strict skipif
condition. The change loosens this condition to ensure tests requiring gated Hugging Face model access are skipped only when genuinely necessary, thereby resolving reported test failures and improving the reliability of CI checks.
Highlights
- Test Condition Adjustment: Modified the
pytest.mark.skipif
decorator intests/llmcompressor/transformers/tracing/test_models.py
to correctly evaluate the presence of theHF_TOKEN
environment variable. The conditionos.getenv("HF_TOKEN") is None
was changed to(not os.getenv("HF_TOKEN"))
to properly handle cases where the token might be an empty string or not set, ensuring tests are skipped only when genuinely necessary.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request modifies the skipif
condition for tests involving gated Hugging Face models. The change from os.getenv("HF_TOKEN") is None
to (not os.getenv("HF_TOKEN"))
broadens the skip condition to include cases where HF_TOKEN
is an empty string, in addition to when it's not set. This resolves an issue where tests might have been running inappropriately when HF_TOKEN
was present but empty. The updated logic is more robust for checking the effective absence of the token. No medium, high, or critical severity issues were found in this code modification.
SUMMARY:
Community user PRs are still failing tracing test checks. This loosens the skip check so it resolves correctly
After merge and rebase, this should also resolve issue for #1521
TEST PLAN:
Confirmed with @dbarbuzzi that this resolved the issue for #1445 .