Skip to content

Disable sequential_targets from modifiers #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Simplify logic around inferring sequential targets by dropping support for sequential targets passed via modifiers

Changes

  • Throw ValueError when sequential_targets is specified on a modifier
  • Remove get_no_split_params function, which is not implemented by infer_sequential_targets
  • Simplify get_sequential_targets logic and rename to infer_sequential_targets

Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@kylesayrs kylesayrs changed the title Remove sequential_targets from modifiers Disable sequential_targets from modifiers Jun 16, 2025
Base automatically changed from kylesayrs/sequential-onloading to main June 17, 2025 20:45
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs force-pushed the kylesayrs/deactivate-sequential_targets branch from c48823f to 78d6975 Compare June 20, 2025 22:25
Signed-off-by: Kyle Sayers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant