-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[Model] Support Gemma 3 backend for Ultravox #15728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Farzad Abdolhosseini <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Farzad Abdolhosseini <[email protected]>
Signed-off-by: Farzad Abdolhosseini <[email protected]>
Signed-off-by: Farzad Abdolhosseini <[email protected]>
Signed-off-by: Farzad Abdolhosseini <[email protected]>
@ywang96 @DarkLight1337 PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. The tests should be able to catch if this breaks older models.
Can you merge from main to fix docker build? |
Can you fix the failing test? |
It turns out this method is not working when using V1 on Llama-based backends. I never noticed this because the embedding size of Gemma-3-4B is larger than their actual text I can't do that in V1 however which leads to the error: |
Pull request was converted to draft
Closing in favour of #17818 |
This PR enables using Ultravox with Gemma 3 backend.
It also adds a new
<|audio|>
token to the tokenizer itself instead of relying on the Llama-specific<|reserved_special_token_0|>
token.