Skip to content

[Model] Support Gemma 3 backend for Ultravox #15728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

farzadab
Copy link
Contributor

@farzadab farzadab commented Mar 28, 2025

This PR enables using Ultravox with Gemma 3 backend.
It also adds a new <|audio|> token to the tokenizer itself instead of relying on the Llama-specific <|reserved_special_token_0|> token.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@farzadab farzadab changed the title [WIP][Model] Support Gemma 3 backend for Ultravox [Model] Support Gemma 3 backend for Ultravox Apr 2, 2025
@farzadab farzadab marked this pull request as ready for review April 2, 2025 18:23
@farzadab
Copy link
Contributor Author

farzadab commented Apr 2, 2025

@ywang96 @DarkLight1337 PTAL.
I have not made the model public yet. If required, I can open source the 1B model for testing purposes.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. The tests should be able to catch if this breaks older models.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 3, 2025 09:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 3, 2025
@DarkLight1337
Copy link
Member

Can you merge from main to fix docker build?

@DarkLight1337
Copy link
Member

Can you fix the failing test?

@farzadab
Copy link
Contributor Author

farzadab commented Apr 4, 2025

It turns out this method is not working when using V1 on Llama-based backends.

I never noticed this because the embedding size of Gemma-3-4B is larger than their actual text vocab_size.
With V0, I can capture the extra dummy audio_token_id and replace it with 0 before computing inputs_embeds.

I can't do that in V1 however which leads to the error: Token id 128256 is out of vocabulary.

@farzadab farzadab marked this pull request as draft April 18, 2025 22:03
auto-merge was automatically disabled April 18, 2025 22:03

Pull request was converted to draft

@farzadab
Copy link
Contributor Author

farzadab commented May 8, 2025

Closing in favour of #17818

@farzadab farzadab closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants