-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[CI/Build] Upgrade lm-eval to 0.4.9 #19962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ye (Charlotte) Qi <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @yeqcharlotte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the lm-eval
dependency to its latest version, 0.4.9, across the project's various requirement specifications. The primary motivation for this change is to unlock new evaluation capabilities, specifically the chartqa
dataset, which relies on this newer version of the library. This ensures the project's CI/build processes are aligned with the latest evaluation tools.
Highlights
- Dependency Upgrade: The
lm-eval
library has been upgraded from version0.4.8
to0.4.9
across all relevantrequirements
files. - New Evaluation Capability: This upgrade enables the use of the
chartqa
evaluation dataset, which is only available withlm-eval
version0.4.9
. - CI/Build Consistency: The version bump is applied consistently in
requirements/nightly_torch_test.txt
,requirements/test.in
, andrequirements/test.txt
to ensure all testing and build environments use the updated dependency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the lm-eval
dependency to version 0.4.9
across the project's requirements files. The change is straightforward and the rationale is clear. I've pointed out a small redundancy in one of the requirements files that could be cleaned up for better maintainability. Otherwise, the changes look good and relying on CI for validation is appropriate for this kind of dependency upgrade.
@@ -22,9 +22,9 @@ peft | |||
runai-model-streamer==0.11.0 | |||
runai-model-streamer-s3==0.11.0 | |||
tensorizer>=2.9.0 | |||
lm-eval==0.4.8 | |||
lm-eval==0.4.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -22,9 +22,9 @@ peft | |||
runai-model-streamer==0.11.0 | |||
runai-model-streamer-s3==0.11.0 | |||
tensorizer>=2.9.0 | |||
lm-eval==0.4.8 | |||
lm-eval==0.4.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we use >= 0.4.9, or just pin to 0.4.9?
Purpose
Used in #19959.
chartqa is only available in 0.4.9. mmmu_eval has too many categories and is too slow to run. So
Test Plan
CI
Used in #19959