[Llama4] Update attn_temperature_tuning

[b8zhong]

Purpose

Since huggingface/transformers#37501 landed

It's the below on HF now:

attn_temperature_tuning (`bool`, *optional*, defaults to `True`):
            Whether to dynamically scale the attention temperature for each query token based on sequence length.
            Recommended for long sequences (e.g., >32k tokens) to maintain stable output results.

So we no longer need this comment

Test Plan

Start the model on TP=8 on H100, loaded fine

Command:

vllm serve /models/Llama4-Scout-17B --tensor-parallel-size 8

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Summary of Changes

Hello @b8zhong, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Llama4 model implementation to align with recent changes in the Hugging Face transformers library, specifically regarding the attn_temperature_tuning configuration parameter. The changes involve removing an obsolete comment and simplifying the boolean evaluation of this parameter, reflecting its updated type upstream.

Highlights

• Code Alignment & Comment Removal: I've removed an outdated TODO comment in vllm/model_executor/models/llama4.py that stated attn_temperature_tuning should be a boolean in Hugging Face. This comment is no longer necessary as the upstream transformers library has already updated this parameter to be a boolean type.
• Logic Simplification: The conditional logic for self.attn_temperature_tuning was simplified. Previously, it checked config.attn_temperature_tuning > 0, which implicitly treated a boolean True as 1. Now, it directly uses config.attn_temperature_tuning, leveraging its explicit boolean type for cleaner and more accurate evaluation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the attn_temperature_tuning logic to align with recent changes in the Hugging Face LlamaConfig, where the attn_temperature_tuning parameter is now a boolean. The removal of the outdated TODO comment and the simplification of the boolean expression enhance code clarity and maintainability.

[b8zhong]

@houseroad I think you left this comment 👍

[houseroad]

Looks good.

[houseroad]

Could you update the test plan about how the changes are verified?

[b8zhong]

@houseroad Sure, I just quickly tested the loading of the model on H100 and it was fine. However, I am out of credits on my provider to benchmark throughput 🙃

[houseroad]

Thanks, that’s fine. Could you paste your test command to the PR description? That will be very helpful

[b8zhong]

@houseroad It's there now!

[yeqcharlotte]

Thanks for fixing this! Yeah it should be removed with latest huggingface side upgrade.