-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-mdbook-structure: Add script. #442
base: master
Are you sure you want to change the base?
Conversation
There seem to be some error messages about using unitialized values, is that fine? Links such as "Partioning notes" are now broken. While "Firmware" is now indented correctly, "Services and daemons" is wrong :/ I'm not sure I love this change, I liked having the numbers :p |
There shouldn't be; i resolved all such errors that were coming up.
Again, working fine here ....
.... as is this. Did you use
Fair enough. :-) If people are happy with the Handbook, and the ToC for it, having numbering that doesn't match the numbering on docs.voidlinux.org, i'm probably okay with that. |
I tried removing |
Output:
|
i just did a fresh clone of my void-docs fork, created a new branch from |
I would love to find out what happened, but yeah, cloning a new repo works cleanly. Somehow it didn't work in my usual repo even when I cleaned it every way I could think of :/ |
53f8465
to
6557cce
Compare
@bobertlo: Any thoughts on this? The options seem to be:
i'll work with whatever others decide. :-) |
Whatever we do, consistency would be best. :) |
How so? |
6557cce
to
687954f
Compare
People wouldn't be able to simply say "Refer to section x.y.z in the Handbook", as the section numbering in the HTML version and the PDF differ substantially (cf. the section numbering of the current PDF compared to the section numbering on docs.voidlinux.org). i've just force-pushed an update to this PR which adds some commentary explaining the issue (and which anticipates code changes/additions i'll start working on - see below). @bobertlo: Okay, thanks - sounds like the third option is the way to go then. :-) i'll implement that asap. |
Hmmm I'm not sure the session numbering should be guaranteed in any way, it's pretty easy to change it for whatever reason; so someone who is using the PDF from the Guaranteeing session numbering in a specific release is interesting, but feels like a lot of work. If you want to disabuse people of that notion, at least, while still having a similar layout to the website, I would go with option 2. If you have started on the code already, though, we can go with 3. Overall, I prefer using the section names. |
Should we make a decision on this one before tagging a first version? I don't think we need to, just want to be sure. If we don't, I can tag the first release tomorrow and update the package then, what do you think? |
Yes, i'd prefer to wait for @bobertlo's opinion on which option to go with. i'd rather we made the right decision for the long-term than to possibly make the wrong decision under short-term time pressures. (Fwiw, my own preferred option is point two.) |
Indeed, I don't think we should rush a decision. That said, do you think we need to wait for a decision to tag a release? We don't have to stick with a certain PDF styling between releases, so shipping a first version as is and iterating from there sounds like a nice idea to me. |
No, i don't think we need to wait. i think the PDF is basically usable as-is. |
687954f
to
e36cabc
Compare
Updated PR so that internal links have the colour of links on docs.voidlinux.org. External links are currently blue, but this can be changed; i think it's a good idea to differentiate internal links from external links, given that the latter will open a browser. |
Additionally add some explanatory comments to `mdbook-latex`. This script uses the `handbook.toc` produced by the first run of `pdflatex` on `handbook.tex` to manually create a ToC in the style of docs.voidlinux.org, which will then be used in the second run of `pdflatex`.
e36cabc
to
f88841a
Compare
For reference, the ToC currently looks like: and the ToC created by this PR looks like: |
I think I kinda prefer the current one, tbh. |
@ericonr: Fair enough. :-) If @the-maldridge agrees with you, i can close this PR and open a new one that simply removes the boxes around links and changes the link colour (the former of which i feel would be a definite improvement). |
This script uses the
handbook.toc
produced by the first run ofpdflatex
onhandbook.tex
to manually create a ToC in the style of docs.voidlinux.org, which will then be used in the second run ofpdflatex
. It includes some special-casing to deal with the infamous "NVIDIA Optimus" entry. :-)i was starting to work on adding section numbers, then realised that the section numbering won't match that produced by LaTeX for each section in the document body. Trying to deal with that might be a non-trivial problem, so i'd rather set it aside for now.
The styling is currently very basic, as i've mainly been focused on getting the fundamentals right - feel free to suggest changes in this regard.