Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVO-4886 - gha secret issues #58

Merged
merged 24 commits into from
Jan 23, 2024

Conversation

TarasDz
Copy link
Contributor

@TarasDz TarasDz commented Dec 15, 2023

This changes should fix the issue with secretes:

[Invalid workflow file: .github/workflows/deploy-api.yml#L19](https://github.com/voltrondata/substrait-fiddle/actions/runs/7183899727/workflow)
The workflow is not valid. .github/workflows/deploy-api.yml (Line: 19, Col: 9): Unrecognized named-value: 'secrets'. Located at position 36 within expression: github.ref == 'refs/heads/main' && secrets.DEPLOY_SSH_KEY && secrets.DEPLOY_HOST_DNS && secrets.DEPLOY_USERNAME && secrets.DEPLOY_TARGET_DIR

Also added path so if there will be any changes in .github/workflow/** to trigger the jobs

@voltrondatabot
Copy link

Copy link
Contributor

@amaldonadomat amaldonadomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make sure that the workflow works before merging this, so please provide some proof that it works. And also agree with amol and assignUser on their comments

@TarasDz TarasDz force-pushed the DVO-4886-gha-secret-issues branch from 61dc882 to 968bc7a Compare January 11, 2024 16:24
@TarasDz TarasDz marked this pull request as draft January 11, 2024 16:29
@TarasDz
Copy link
Contributor Author

TarasDz commented Jan 18, 2024

Hello @amol- @assignUser @amaldonadomat

The recent PR aims to facilitate the deployment of substrait-fiddle using docker-compose. This will be achieved by implementing a new workflow that will be triggered if changes are pushed to the main branch or if any of the specified paths are modified. These paths include client/**, api/**, github/workflows/deploy-api-client.yml, and docker-compose.yaml

In order to run docker-compose on a remote host, we will use SSH-Compose. This will allow as to manage and configure the remote host efficiently

To deploy substrait-fiddle on the host, certain prerequisites must be met. These include pre-configuring some packages on the host and having a deploy user to run docker. The PR is in labs repo, we configured the instance to create with security groups that open ports 22, 80, and 443. This will ensure that the necessary connections are available

I was able to create the instance using pulumi with pre-configured packages, then I run GHA on my fork to deploy substrait-fiddle on new host:
Screenshot 2024-01-18 at 11 07 02 AM

currently it's running on instance IP: http://18.116.28.34/
we still working on DNS transfer, and once it will be finished we will update the IaC code

Please review this PR and let us know if you have any questions or comments

@TarasDz TarasDz marked this pull request as ready for review January 18, 2024 17:12
Copy link
Contributor

@amaldonadomat amaldonadomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TarasDz
This looks great, much easier to deploy with the docker compose

Copy link
Contributor

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow what a cool way to deploy, thanks! I left some minor best practice security suggestions.

@TarasDz TarasDz merged commit 90a7678 into voltrondata:main Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants