-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVO-4886 - gha secret issues #58
DVO-4886 - gha secret issues #58
Conversation
DVO-4880: add workflow_dispatch for substrait-fiddle (voltrondata#57)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to make sure that the workflow works before merging this, so please provide some proof that it works. And also agree with amol and assignUser on their comments
61dc882
to
968bc7a
Compare
Hello @amol- @assignUser @amaldonadomat The recent PR aims to facilitate the deployment of In order to run To deploy I was able to create the instance using currently it's running on instance IP: http://18.116.28.34/ Please review this PR and let us know if you have any questions or comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TarasDz
This looks great, much easier to deploy with the docker compose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow what a cool way to deploy, thanks! I left some minor best practice security suggestions.
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
This changes should fix the issue with secretes:
Also added path so if there will be any changes in
.github/workflow/**
to trigger the jobs