Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.2 #11

Merged
merged 8 commits into from
Oct 3, 2024
Merged

v1.0.2 #11

merged 8 commits into from
Oct 3, 2024

Conversation

jamiemccarthy
Copy link
Contributor

This merges the 2019-2022 upstream changes of this breakers gem back into our custom version.

In particular this PR merges in a pipeline change. This uses the recommended "pipeline" block variable for the redis multi method, which is better than using the global redis variable.

When using redis 4.x, the previous version of breakers was emitting this deprecation warning:

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

So upgrading to this new version should eliminate that warning and clear up logs.

The only other change of note is that its statsd duration measure changes from seconds to milliseconds, but I do not believe Vox Media is using that data anywhere.

@jamiemccarthy
Copy link
Contributor Author

jamiemccarthy commented Oct 3, 2024

I'm pleasantly surprised some of the new CI passed. The one that failed, failed with the error

CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled

image

@jamiemccarthy jamiemccarthy merged commit 0a6ca24 into master Oct 3, 2024
2 of 3 checks passed
@jamiemccarthy jamiemccarthy deleted the jm-v1.0.2 branch October 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants