Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the 2019-2022 upstream changes of this
breakers
gem back into our custom version.In particular this PR merges in a
pipeline
change. This uses the recommended "pipeline" block variable for the redismulti
method, which is better than using the global redis variable.When using redis 4.x, the previous version of
breakers
was emitting this deprecation warning:So upgrading to this new version should eliminate that warning and clear up logs.
The only other change of note is that its statsd
duration
measure changes from seconds to milliseconds, but I do not believe Vox Media is using that data anywhere.