Add Author field to the attachment #21
Conversation
|
I'll be watching this one, I actually want the author on the slack messages as well. |
|
...this is nice... |
|
Any progress on getting this merged? I've got a couple of requests on this exact feature.... |
|
Hello! Any news about this PR? This feature interests me :) |
|
@ThomasEg @thiago-scherrer hello! we've had some changes on the team hence the slow response. We will get to this asap! Thanks for bearing with us. |
|
I would like author as well :) |
|
@torbjornvatn could you please resolve the conflicts? :) |
|
@kimegede fixed it now |
|
Really nice @torbjornvatn! Big high five 🙏 |
| it('show author/actor', () => { | ||
| const attachments = buildSlackAttachments({ status: 'STARTED', color: 'good', github: GITHUB_PUSH_EVENT }); | ||
|
|
||
| expect(attachments[0].fields.find(a => a.title === 'Author')).toEqual({ | ||
| title: 'Author', | ||
| value: 'Codertocat', | ||
| short: true, | ||
| }); | ||
| }); |
|
@pam- can we soon get this one merged please? :) |
|
Is there maybe someone else we will need to tag, to get included and being able to move forward with this? |
|
@kimegede We are running with less engineers than usual and might not be able to maintain this for a while. I will confirm that merging this doesn't interfere with any of our repos before pushing the button. For future features, I encourage you to fork this and make it your own. Thanks! |
|
Thanks for the feedback Pam, that's understood. |
Purpose
Add a new field to the Slack attachment with the Author/Actor from the github event triggering the action
Fixes #14
Changelog
CHANGELOG.mdunder "Unreleased" with the changes included in this PR.