Fix golangci-lint issues (prebid#3679)

adapters/adgeneration/adgeneration_test.go

@@ -259,6 +259,7 @@ func checkBidResponse(t *testing.T, bidderResponse *adapters.BidderResponse, exp
 	var expectedCrID string = "Dummy_supership.jp"
 	var extectedDealID string = "test-deal-id"
 
+	//nolint: staticcheck // false positive SA5011: possible nil pointer dereference
 	assert.Equal(t, expectedCurrency, bidderResponse.Currency)
 	assert.Equal(t, 1, len(bidderResponse.Bids))
 	assert.Equal(t, expectedID, bidderResponse.Bids[0].Bid.ID)

adapters/adtarget/adtarget.go

@@ -174,7 +174,11 @@ func validateImpressionAndSetExt(imp *openrtb2.Imp) (int, error) {
 	impExtBuffer, err = json.Marshal(&adtargetImpExt{
 		Adtarget: impExt,
 	})
-
+	if err != nil {
+		return 0, &errortypes.BadInput{
+			Message: fmt.Sprintf("ignoring imp id=%s, error while encoding impExt, err: %s", imp.ID, err),
+		}
+	}
 	if impExt.BidFloor > 0 {
 		imp.BidFloor = impExt.BidFloor
 	}

adapters/advangelists/advangelists.go

@@ -199,7 +199,7 @@ func (adapter *AdvangelistsAdapter) buildEndpointURL(params *openrtb_ext.ExtImpA
 
 // MakeBids translates advangelists bid response to prebid-server specific format
 func (adapter *AdvangelistsAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) {
-	var msg = ""
+	var msg string
 	if response.StatusCode == http.StatusNoContent {
 		return nil, nil
 	}

adapters/algorix/algorix.go

@@ -142,6 +142,9 @@ func preProcess(request *openrtb2.BidRequest) {
 				videoCopy := *request.Imp[i].Video
 				videoExt := algorixVideoExt{Rewarded: 1}
 				videoCopy.Ext, err = json.Marshal(&videoExt)
+				if err != nil {
+					continue
+				}
 				request.Imp[i].Video = &videoCopy
 			}
 		}

adapters/beintoo/beintoo.go

@@ -23,7 +23,7 @@ func (a *BeintooAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *ada
 
 	if len(request.Imp) == 0 {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("No Imps in Bid Request"),
+			Message: "No Imps in Bid Request",
 		}}
 	}
 
@@ -36,7 +36,7 @@ func (a *BeintooAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *ada
 	data, err := json.Marshal(request)
 	if err != nil {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("Error in packaging request to JSON"),
+			Message: "Error in packaging request to JSON",
 		}}
 	}
 
@@ -95,7 +95,7 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 
 	if imp.Banner == nil {
 		return &errortypes.BadInput{
-			Message: fmt.Sprintf("Request needs to include a Banner object"),
+			Message: "Request needs to include a Banner object",
 		}
 	}
 
@@ -105,7 +105,7 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 	if banner.W == nil && banner.H == nil {
 		if len(banner.Format) == 0 {
 			return &errortypes.BadInput{
-				Message: fmt.Sprintf("Need at least one size to build request"),
+				Message: "Need at least one size to build request",
 			}
 		}
 		format := banner.Format[0]

adapters/between/between.go

@@ -24,7 +24,7 @@ func (a *BetweenAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *ada
 	var errors []error
 	if len(request.Imp) == 0 {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("No valid Imps in Bid Request"),
+			Message: "No valid Imps in Bid Request",
 		}}
 	}
 	ext, errors := preprocess(request)
@@ -40,7 +40,7 @@ func (a *BetweenAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *ada
 	data, err := json.Marshal(request)
 	if err != nil {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("Error in packaging request to JSON"),
+			Message: "Error in packaging request to JSON",
 		}}
 	}
 	headers := http.Header{}
@@ -103,14 +103,14 @@ func (a *BetweenAdapter) buildEndpointURL(e *openrtb_ext.ExtImpBetween) (string,
 func buildImpBanner(imp *openrtb2.Imp) error {
 	if imp.Banner == nil {
 		return &errortypes.BadInput{
-			Message: fmt.Sprintf("Request needs to include a Banner object"),
+			Message: "Request needs to include a Banner object",
 		}
 	}
 	banner := *imp.Banner
 	if banner.W == nil && banner.H == nil {
 		if len(banner.Format) == 0 {
 			return &errortypes.BadInput{
-				Message: fmt.Sprintf("Need at least one size to build request"),
+				Message: "Need at least one size to build request",
 			}
 		}
 		format := banner.Format[0]

adapters/bluesea/bluesea.go

@@ -97,7 +97,7 @@ func extraImpExt(imp *openrtb2.Imp) (*openrtb_ext.ExtImpBluesea, error) {
 	}
 	if len(blueseaImpExt.PubId) == 0 || len(blueseaImpExt.Token) == 0 {
 		return nil, &errortypes.BadInput{
-			Message: fmt.Sprintf("Error in parsing imp.ext.bidder, empty pubid or token"),
+			Message: "Error in parsing imp.ext.bidder, empty pubid or token",
 		}
 	}
 	return &blueseaImpExt, nil

adapters/cadent_aperture_mx/cadentaperturemx.go

@@ -38,7 +38,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E
 
 	if len(request.Imp) == 0 {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("No Imps in Bid Request"),
+			Message: "No Imps in Bid Request",
 		}}
 	}
 
@@ -51,7 +51,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E
 	data, err := json.Marshal(request)
 	if err != nil {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("Error in packaging request to JSON"),
+			Message: "Error in packaging request to JSON",
 		}}
 	}
 
@@ -117,7 +117,7 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 
 	if imp.Banner == nil {
 		return &errortypes.BadInput{
-			Message: fmt.Sprintf("Request needs to include a Banner object"),
+			Message: "Request needs to include a Banner object",
 		}
 	}
 
@@ -127,7 +127,7 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 	if banner.W == nil && banner.H == nil {
 		if len(banner.Format) == 0 {
 			return &errortypes.BadInput{
-				Message: fmt.Sprintf("Need at least one size to build request"),
+				Message: "Need at least one size to build request",
 			}
 		}
 		format := banner.Format[0]
@@ -144,13 +144,13 @@ func buildImpVideo(imp *openrtb2.Imp) error {
 
 	if len(imp.Video.MIMEs) == 0 {
 		return &errortypes.BadInput{
-			Message: fmt.Sprintf("Video: missing required field mimes"),
+			Message: "Video: missing required field mimes",
 		}
 	}
 
 	if (imp.Video.H == nil || *imp.Video.H == 0) && (imp.Video.W == nil || *imp.Video.W == 0) {
 		return &errortypes.BadInput{
-			Message: fmt.Sprintf("Video: Need at least one size to build request"),
+			Message: "Video: Need at least one size to build request",
 		}
 	}
 

adapters/connectad/connectad.go

@@ -32,14 +32,14 @@ func (a *ConnectAdAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *a
 
 	if errs := preprocess(request); len(errs) > 0 {
 		return nil, append(errs, &errortypes.BadInput{
-			Message: fmt.Sprintf("Error in preprocess of Imp"),
+			Message: "Error in preprocess of Imp",
 		})
 	}
 
 	data, err := json.Marshal(request)
 	if err != nil {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("Error in packaging request to JSON"),
+			Message: "Error in packaging request to JSON",
 		}}
 	}
 
@@ -183,7 +183,7 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 
 	if imp.Banner == nil {
 		return &errortypes.BadInput{
-			Message: fmt.Sprintf("We need a Banner Object in the request"),
+			Message: "We need a Banner Object in the request",
 		}
 	}
 
@@ -193,7 +193,7 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 
 		if len(banner.Format) == 0 {
 			return &errortypes.BadInput{
-				Message: fmt.Sprintf("At least one size is required"),
+				Message: "At least one size is required",
 			}
 		}
 		format := banner.Format[0]

adapters/consumable/consumable.go

@@ -89,12 +89,10 @@ func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.R
 
 	bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(request.Imp))
 	bidResponse.Currency = response.Cur
-	var errors []error
 	for _, seatBid := range response.SeatBid {
 		for i, bid := range seatBid.Bid {
 			bidType, err := getMediaTypeForBid(bid)
 			if err != nil {
-				errors = append(errors, err)
 				continue
 			}
 			var bidVideo *openrtb_ext.ExtBidPrebidVideo

adapters/deepintent/deepintent.go

@@ -151,7 +151,7 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 
 	if imp.Banner == nil {
 		return &errortypes.BadInput{
-			Message: fmt.Sprintf("We need a Banner Object in the request"),
+			Message: "We need a Banner Object in the request",
 		}
 	}
 
@@ -161,7 +161,7 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 
 		if len(banner.Format) == 0 {
 			return &errortypes.BadInput{
-				Message: fmt.Sprintf("At least one size is required"),
+				Message: "At least one size is required",
 			}
 		}
 		format := banner.Format[0]

adapters/definemedia/definemedia.go

@@ -99,7 +99,7 @@ func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
 				return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))
 			}
 			return "", &errortypes.BadServerResponse{
-				Message: fmt.Sprintf("Invalid mediatype in the impression"),
+				Message: "Invalid mediatype in the impression",
 			}
 		}
 	}

adapters/dmx/dmx.go

@@ -224,13 +224,13 @@ func (adapter *DmxAdapter) MakeBids(request *openrtb2.BidRequest, externalReques
 
 	if http.StatusBadRequest == response.StatusCode {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("Unexpected status code 400"),
+			Message: "Unexpected status code 400",
 		}}
 	}
 
 	if http.StatusOK != response.StatusCode {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("Unexpected response no status code"),
+			Message: "Unexpected response no status code",
 		}}
 	}
 

adapters/e_volution/evolution.go

@@ -92,7 +92,7 @@ func (a *adapter) MakeBids(
 
 	if len(bidResp.SeatBid) == 0 {
 		return nil, []error{&errortypes.BadServerResponse{
-			Message: fmt.Sprintf("Empty seatbid"),
+			Message: "Empty seatbid",
 		}}
 	}
 

adapters/gamma/gamma.go

@@ -267,7 +267,7 @@ func (a *GammaAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRe
 				})
 			} else {
 				err := &errortypes.BadServerResponse{
-					Message: fmt.Sprintf("Missing Ad Markup. Run with request.debug = 1 for more info"),
+					Message: "Missing Ad Markup. Run with request.debug = 1 for more info",
 				}
 				errs = append(errs, err)
 			}

adapters/gamoshi/gamoshi.go

@@ -55,7 +55,7 @@ func (a *GamoshiAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *ada
 
 	if !validImpExists {
 		err := &errortypes.BadInput{
-			Message: fmt.Sprintf("No valid impression in the bid request"),
+			Message: "No valid impression in the bid request",
 		}
 		errs = append(errs, err)
 		return nil, errs

adapters/grid/grid.go

@@ -2,6 +2,7 @@ package grid
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"net/http"
 	"sort"
@@ -394,8 +395,12 @@ func (a *GridAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalReq
 
 	for _, sb := range bidResp.SeatBid {
 		for i := range sb.Bid {
-			bidMeta, err := getBidMeta(sb.Bid[i].Ext)
+			bidMeta, err := getBidMeta(sb.Bid[i].Ext) //nolint: ineffassign,staticcheck // ineffectual assignment to err
+
 			bidType, err := getMediaTypeForImp(sb.Bid[i].ImpID, internalRequest.Imp, sb.Bid[i])
+			if err != nil {
+				return nil, []error{err}
+			}
 			if sb.Bid[i].AdmNative != nil && sb.Bid[i].AdM == "" {
 				if bytes, err := json.Marshal(sb.Bid[i].AdmNative); err == nil {
 					sb.Bid[i].AdM = string(bytes)
@@ -427,6 +432,9 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server co
 }
 
 func getBidMeta(ext json.RawMessage) (*openrtb_ext.ExtBidPrebidMeta, error) {
+	if ext == nil {
+		return nil, errors.New("nil ext passed to getBidMeta")
+	}
 	var bidExt GridBidExt
 
 	if err := json.Unmarshal(ext, &bidExt); err != nil {

adapters/imds/imds.go

@@ -71,7 +71,7 @@ func (a *adapter) makeRequest(request *openrtb2.BidRequest) (*adapters.RequestDa
 		// if the bid request is missing seatId or TagId then ignore it
 		if validExtImpObj.SeatId == "" || validExtImpObj.TagId == "" {
 			errs = append(errs, &errortypes.BadServerResponse{
-				Message: fmt.Sprintf("Invalid Impression"),
+				Message: "Invalid Impression",
 			})
 			continue
 		}
@@ -91,7 +91,7 @@ func (a *adapter) makeRequest(request *openrtb2.BidRequest) (*adapters.RequestDa
 
 	if firstExtImp == nil || firstExtImp.SeatId == "" || firstExtImp.TagId == "" {
 		return nil, append(errs, &errortypes.BadServerResponse{
-			Message: fmt.Sprintf("Invalid Impression"),
+			Message: "Invalid Impression",
 		})
 	}
 	// this is where the empty seatId is filled

adapters/mobfoxpb/mobfoxpb.go

@@ -50,7 +50,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E
 	key, errKey := jsonparser.GetString(imp.Ext, "bidder", "key")
 	if errTag != nil && errKey != nil {
 		errs = append(errs, &errortypes.BadInput{
-			Message: fmt.Sprintf("Invalid or non existing key and tagId, atleast one should be present"),
+			Message: "Invalid or non existing key and tagId, at least one should be present",
 		})
 		return nil, errs
 	}

adapters/mobfoxpb/mobfoxpbtest/supplemental/bad-imp-ext.json

@@ -34,7 +34,7 @@
     },
     "expectedMakeRequestsErrors": [
         {
-            "value": "Invalid or non existing key and tagId, atleast one should be present",
+            "value": "Invalid or non existing key and tagId, at least one should be present",
             "comparison": "literal"
         }
     ]

adapters/mobfoxpb/mobfoxpbtest/supplemental/imp_ext_empty_object.json

@@ -30,7 +30,7 @@
     },
     "expectedMakeRequestsErrors": [
         {
-            "value": "Invalid or non existing key and tagId, atleast one should be present",
+            "value": "Invalid or non existing key and tagId, at least one should be present",
             "comparison": "literal"
         }
     ]

adapters/mobfoxpb/mobfoxpbtest/supplemental/imp_ext_string.json

@@ -30,7 +30,7 @@
     },
     "expectedMakeRequestsErrors": [
         {
-            "value": "Invalid or non existing key and tagId, atleast one should be present",
+            "value": "Invalid or non existing key and tagId, at least one should be present",
             "comparison": "literal"
         }
     ]

adapters/nobid/nobid.go

@@ -30,7 +30,7 @@ func (a *NoBidAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapt
 
 	if len(request.Imp) == 0 {
 		return nil, []error{&errortypes.BadInput{
-			Message: fmt.Sprintf("No Imps in Bid Request"),
+			Message: "No Imps in Bid Request",
 		}}
 	}