Skip to content

Commit

Permalink
fix semgrep error message (prebid#3038)
Browse files Browse the repository at this point in the history
co-authored by @onkarvhanumante
  • Loading branch information
onkarvhanumante authored Aug 21, 2023
1 parent 379466c commit 66c38fa
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .semgrep/adapter/parse-bid-type-check.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
rules:
- id: parse-bid-type-check
message: The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to $ORTBTYPE. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the [MType](https://github.com/prebid/openrtb/blob/main/openrtb2/bid.go#L334) field in the response to accurately determine the media type for the impression.
message: >
Prebid server expects the media type to be explicitly set in the adapter response.
Therefore, recommends implementing a pattern where the adapter server sets the [MType](https://github.com/prebid/openrtb/blob/main/openrtb2/bid.go#L334) field in the response to accurately determine the media type for the impression.
languages:
- go
severity: WARNING
Expand Down

0 comments on commit 66c38fa

Please sign in to comment.