Generic schemas #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Stream discover only works for use cases where an catalog is provided as an input. My use case doesn't care so much about the input catalog (which would take a long time to generate) as it is about getting the data comprehensively.
The current
discover_streamsmethod relies on a list ofaliasesreturned from elasticsearch for each of the indexes. This also does not fit my use case. None of our indexes have aliases.This solution
Here I provide edits to the
discover_streamsmethod that, for me at least, enables me to discover the full list of indexes whether or not they have aliases and extract each index with default elasticsearch-based record keys. This will require the downstream target to be able to ingest json objects or otherwise require some other meltano based methodology for flattening.