fix tests and linting errors

voxmedia · Feb 28, 2022 · 0d38dae · 0d38dae
1 parent 7fd81d5
commit 0d38dae
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 11 deletions.
diff --git a/tap_instagram/streams.py b/tap_instagram/streams.py
@@ -188,7 +188,12 @@ class MediaStream(InstagramStream):
 
     def make_since_param(self, context: Optional[dict]) -> datetime:
         state_ts = self.get_starting_timestamp(context)
-        return pendulum.instance(state_ts).subtract(days=self.config["media_insights_lookback_days"])
+        if state_ts:
+            return pendulum.instance(state_ts).subtract(
+                days=self.config["media_insights_lookback_days"]
+            )
+        else:
+            return state_ts
 
     def get_url_params(
         self, context: Optional[dict], next_page_token: Optional[Any]
@@ -210,7 +215,9 @@ def get_child_context(self, record: dict, context: Optional[dict]) -> dict:
     def parse_response(self, response: requests.Response) -> Iterable[dict]:
         for row in extract_jsonpath(self.records_jsonpath, input=response.json()):
             if "timestamp" in row:
-                row["timestamp"] = pendulum.parse(row["timestamp"]).format("YYYY-MM-DD HH:mm:ss")
+                row["timestamp"] = pendulum.parse(row["timestamp"]).format(
+                    "YYYY-MM-DD HH:mm:ss"
+                )
             yield row
 
 
@@ -361,7 +368,9 @@ def get_child_context(self, record: dict, context: Optional[dict]) -> dict:
     def parse_response(self, response: requests.Response) -> Iterable[dict]:
         for row in extract_jsonpath(self.records_jsonpath, input=response.json()):
             if "timestamp" in row:
-                row["timestamp"] = pendulum.parse(row["timestamp"]).format("YYYY-MM-DD HH:mm:ss")
+                row["timestamp"] = pendulum.parse(row["timestamp"]).format(
+                    "YYYY-MM-DD HH:mm:ss"
+                )
             yield row
 
 
@@ -392,7 +401,9 @@ class MediaChildrenStream(MediaStream):
     def parse_response(self, response: requests.Response) -> Iterable[dict]:
         for row in extract_jsonpath(self.records_jsonpath, input=response.json()):
             if "timestamp" in row:
-                row["timestamp"] = pendulum.parse(row["timestamp"]).format("YYYY-MM-DD HH:mm:ss")
+                row["timestamp"] = pendulum.parse(row["timestamp"]).format(
+                    "YYYY-MM-DD HH:mm:ss"
+                )
             yield row
 
 
@@ -528,14 +539,18 @@ def parse_response(self, response: requests.Response) -> Iterable[dict]:
                             item = {
                                 "context": key,
                                 "value": value,
-                                "end_time": pendulum.parse(values["end_time"]).format("YYYY-MM-DD HH:mm:ss"),
+                                "end_time": pendulum.parse(values["end_time"]).format(
+                                    "YYYY-MM-DD HH:mm:ss"
+                                ),
                             }
                             item.update(base_item)
                             yield item
                     else:
                         values.update(base_item)
                         if "end_time" in values:
-                            values["end_time"] = pendulum.parse(values["end_time"]).format("YYYY-MM-DD HH:mm:ss")
+                            values["end_time"] = pendulum.parse(
+                                values["end_time"]
+                            ).format("YYYY-MM-DD HH:mm:ss")
                         yield values
 
 
@@ -687,14 +702,18 @@ def parse_response(self, response: requests.Response) -> Iterable[dict]:
                             item = {
                                 "context": key,
                                 "value": value,
-                                "end_time": pendulum.parse(values["end_time"]).format("YYYY-MM-DD HH:mm:ss"),
+                                "end_time": pendulum.parse(values["end_time"]).format(
+                                    "YYYY-MM-DD HH:mm:ss"
+                                ),
                             }
                             item.update(base_item)
                             yield item
                     else:
                         values.update(base_item)
                         if "end_time" in values:
-                            values["end_time"] = pendulum.parse(values["end_time"]).format("YYYY-MM-DD HH:mm:ss")
+                            values["end_time"] = pendulum.parse(
+                                values["end_time"]
+                            ).format("YYYY-MM-DD HH:mm:ss")
                         yield values
 
 
@@ -827,14 +846,18 @@ def parse_response(self, response: requests.Response) -> Iterable[dict]:
                             item = {
                                 "context": key,
                                 "value": value,
-                                "end_time": pendulum.parse(values["end_time"]).format("YYYY-MM-DD HH:mm:ss"),
+                                "end_time": pendulum.parse(values["end_time"]).format(
+                                    "YYYY-MM-DD HH:mm:ss"
+                                ),
                             }
                             item.update(base_item)
                             yield item
                     else:
                         values.update(base_item)
                         if "end_time" in values:
-                            values["end_time"] = pendulum.parse(values["end_time"]).format("YYYY-MM-DD HH:mm:ss")
+                            values["end_time"] = pendulum.parse(
+                                values["end_time"]
+                            ).format("YYYY-MM-DD HH:mm:ss")
                         yield values
 
 

diff --git a/tap_instagram/tap.py b/tap_instagram/tap.py
@@ -64,7 +64,7 @@ class TapInstagram(Tap):
             th.IntegerType,
             default=60,
             description="The tap fetches media insights for Media objects posted in the last `insights_lookback_days` "
-                        "days - defaults to 14 days if not provided"
+            "days - defaults to 14 days if not provided",
         ),
         th.Property(
             "start_date",