Implement --domain option

[bastelfreak]

Previously, the domain example.com was hardcoded for the beaker instances. This is now configureable.

[bastelfreak]

This is related to voxpupuli/beaker-hostgenerator#261 (comment).

This now adds a bunch of example.com strings into the method headers and I'm not really happy about it. Should we get rid of this default value?

[ekohl]

Looking at this I'm wondering if we should make domain an Optional[String] and drop use_fqdn. This could map nicely to where we specify the domain as an option to beaker-hostgenerator and stop overriding the hostname.

For compatibility I'd say that it should append domain if it's set, otherwise fall back to use_fqdn. So roughly

def os_release_to_setfile(os, release, use_fqdn: false, pidfile_workaround: false, domain: nil)
  domain ||= 'example.com' if use_fqdn
  options = {}
  options[:hostname] = "#{name}.#{domain}" if domain
end

[bastelfreak]

okay it was clearly too early when I wrote that code.

[bastelfreak]

@ekohl I implemented your suggestion

[bastelfreak]

@ekohl, this looks good to me. Are you fine with merging it?