-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_pseudo_unitary #993
base: master
Are you sure you want to change the base?
Add is_pseudo_unitary #993
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #993 +/- ##
======================================
Coverage 97.9% 97.9%
======================================
Files 170 171 +1
Lines 3328 3340 +12
Branches 728 731 +3
======================================
+ Hits 3260 3272 +12
Misses 44 44
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this, but I will away @purva-thakre 's review as well which may likely be next week sometime. Thanks for your contribution, @harshvardhan-pandey , and looking forward to seeing more of your work!
Ah, one thing I noticed is to request that you please add a test to cover all of the branches in the function. You can refer to the code-cov report for where the missing coverage is: |
@vprusso I did update the issue of code coverage in a later commit. Though I don't know why the coverage percentage is still the same. Could you just confirm if there is still an issue on my end or if it takes some time to update? |
Hmm, that's interesting, yes, I do see your tests for the lines in question. I believe you're correct and this is likely okay, but I'll wait for @purva-thakre to confirm when she has time. Thanks for pointing that out! |
Description
Added feature to check if a matrix is pseudo unitary (in regards to Issue 767).
Changes
Checklist
Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.
Additional information is available in the documentation.
ruff
for errors related to code style and formatting.pytest
.Sphinx
build can be checked locally for any failures related to your PRlinkcheck
to check for broken links in the documentationdoctest
to verify the examples in the function docstrings work as expected.