Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(reactivity): simplify if condition #1002

Merged
merged 2 commits into from
Apr 20, 2020
Merged

refactor(reactivity): simplify if condition #1002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a58f15
refactor(reactivity): simplify if condition
limichange Apr 20, 2020
0ab3bc3
refactor(reactivity): reset if condition
limichange Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/reactivity/src/effect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ export function track(target: object, type: TrackOpTypes, key: unknown) {
return
}
let depsMap = targetMap.get(target)
if (depsMap === void 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it only want to check the deps map is not undefined, about void 0: lessfish/underscore-analysis#1

if (!depsMap) {
targetMap.set(target, (depsMap = new Map()))
}
let dep = depsMap.get(key)
if (dep === void 0) {
if (!dep) {
depsMap.set(key, (dep = new Set()))
}
if (!dep.has(activeEffect)) {
Expand All @@ -171,15 +171,15 @@ export function trigger(
oldTarget?: Map<unknown, unknown> | Set<unknown>
) {
const depsMap = targetMap.get(target)
if (depsMap === void 0) {
if (!depsMap) {
// never been tracked
return
}

const effects = new Set<ReactiveEffect>()
const computedRunners = new Set<ReactiveEffect>()
const add = (effectsToAdd: Set<ReactiveEffect> | undefined) => {
if (effectsToAdd !== void 0) {
if (effectsToAdd) {
effectsToAdd.forEach(effect => {
if (effect !== activeEffect || !shouldTrack) {
if (effect.options.computed) {
Expand Down Expand Up @@ -238,7 +238,7 @@ export function trigger(
oldTarget
})
}
if (effect.options.scheduler !== void 0) {
if (effect.options.scheduler) {
effect.options.scheduler(effect)
} else {
effect()
Expand Down