fix(compiler-vapor): fix asset import from public directory #13630

Gianthard-cyh · 2025-07-14T17:15:43Z

Problem statement

Change summary

Add imports for TransformContext in compiler-vapor.
Modify expression generator to treat the expression of imported public asset properly.
Generate asset imports.

Closes #13623.

… directory

coderabbitai · 2025-07-14T17:15:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-15T02:54:55Z

Size Report

Bundles

File	Size	Gzip	Brotli
compiler-dom.global.prod.js	84.1 kB	29.8 kB	26.2 kB
runtime-dom.global.prod.js	104 kB	39.1 kB	35.2 kB
vue.global.prod.js	162 kB	59.3 kB	52.8 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	47.2 kB	18.5 kB	16.9 kB
createApp	56 kB	21.6 kB	19.7 kB
createApp + vaporInteropPlugin	68.5 kB	25.8 kB	23.6 kB
createVaporApp	21 kB	8.31 kB	7.6 kB
createSSRApp	60.3 kB	23.4 kB	21.3 kB
defineCustomElement	61 kB	23.1 kB	21.1 kB
overall	70.5 kB	26.8 kB	24.5 kB

pkg-pr-new · 2025-07-15T02:55:06Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13630

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13630

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13630

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13630

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13630

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13630

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13630

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13630

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13630

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13630

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13630

vue

npm i https://pkg.pr.new/vue@13630

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13630

commit: d50620c

edison1105 · 2025-07-15T03:10:15Z

packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap

@@ -1,5 +1,17 @@
 // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

+exports[`compile > asset imports > from public directory 1`] = `
+"import { setProp as _setProp, renderEffect as _renderEffect, template as _template } from 'vue';
+import _imports_0 from '/vite.svg';


import _imports_0 from '/vite.svg'; const t0 = _template(`<img src="${_imports_0}">`, true)

It should be done like this to avoid renderEffect and setProp.

Hi! Thanks for the suggestion — I’ve tried to move _imports_0 into the template string as recommended to avoid renderEffect and setProp.

core/packages/compiler-vapor/src/generators/template.ts

Lines 7 to 20 in 65abd6e

export function genTemplates(

templates: string[],

rootIndex: number | undefined,

{ helper }: CodegenContext,

): string {

return templates

.map(

(template, i) =>

`const t${i} = ${helper('template')}(${JSON.stringify(

template,

)}${i === rootIndex ? ', true' : ''})\n`,

)

.join('')

}

However, the genTemplates function still uses JSON.stringify(), which wraps the entire template in double quotes and escapes inner quotes. That prevents me from generating template literals like:

const t0 = _template(`<img src="${_imports_0}">`, true)

I also tried string concatenation:

template += ` ${key.content}=""+${values[0].content}+""`

But this results in a normal string with escaped quotes.

const t0 = _template("<img src=\"\"+_imports_0+\"\">")

Let me know if you have any thoughts or preferred direction on this — happy to collaborate on the final approach!

Gianthard-cyh · 2025-07-15T15:02:57Z

Hi! @edison1105
I've committed a version that replaces JSON.stringify with a custom escape function, and wraps the template strings with backticks (`) instead of double quotes ("). I bundled and tested the output and it successfully fixes the issue.

This change breaks the existing unit tests because previous snapshots were based on template strings wrapped with double quotes. I'm not sure whether this change might break anything else beyond the existing tests, so I’d appreciate your review and feedback before proceeding further.

Gianthard-cyh added 2 commits July 15, 2025 00:18

fix(vapor): Fix asset import from public directory.

d0b7210

test(compiler-vapor): add snapshot test for asset imports from public…

d50620c

… directory

edison1105 reviewed Jul 15, 2025

View reviewed changes

edison1105 added scope: vapor related to vapor mode scope: compiler wait changes labels Jul 15, 2025

wip: avoid renderEffect and setProp.

2b9f5fd

edison1105 linked an issue Jul 16, 2025 that may be closed by this pull request

[Vapor] Using image from public directory causes error #13623

Open

edison1105 moved this to Vapor in Next Minor Jul 16, 2025

edison1105 added this to Next Minor Jul 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(compiler-vapor): fix asset import from public directory #13630

fix(compiler-vapor): fix asset import from public directory #13630

Gianthard-cyh commented Jul 14, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 14, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

pkg-pr-new bot commented Jul 15, 2025

Uh oh!

edison1105 Jul 15, 2025 •

edited

Loading

Uh oh!

Gianthard-cyh Jul 15, 2025 •

edited

Loading

Uh oh!

Gianthard-cyh commented Jul 15, 2025

Uh oh!

Uh oh!

	export function genTemplates(
	templates: string[],
	rootIndex: number \| undefined,
	{ helper }: CodegenContext,
	): string {
	return templates
	.map(
	(template, i) =>
	`const t${i} = ${helper('template')}(${JSON.stringify(
	template,
	)}${i === rootIndex ? ', true' : ''})\n`,
	)
	.join('')
	}

Uh oh!

fix(compiler-vapor): fix asset import from public directory #13630

Are you sure you want to change the base?

fix(compiler-vapor): fix asset import from public directory #13630

Conversation

Gianthard-cyh commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem statement

Change summary

Uh oh!

coderabbitai bot commented Jul 14, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 15, 2025

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new bot commented Jul 15, 2025

Uh oh!

edison1105 Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gianthard-cyh Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gianthard-cyh commented Jul 15, 2025

Uh oh!

Uh oh!

Gianthard-cyh commented Jul 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

edison1105 Jul 15, 2025 •

edited

Loading

Gianthard-cyh Jul 15, 2025 •

edited

Loading