-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add dashboard creation #36
base: master
Are you sure you want to change the base?
Feature/add dashboard creation #36
Conversation
metabase_api/metabase_api.py
Outdated
@@ -642,6 +642,35 @@ def create_segment(self, segment_name, column_name, column_values, segment_descr | |||
|
|||
|
|||
|
|||
def create_dashboard(self, name, description=None, parameters=None, cache_ttl=None, collection_id=None, collection_position=None, collection_name=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"parameters" and "cache_ttl" are not used in the function.
The function should allow passing custom json as argument to customize the dashboard (I assume the "parameters" option was supposed to do that). Currently only the name and description of the dashboard are customizable using this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, sorry to bother, I'm correcting this asap
Some thoughts after your remarks :
I'll try to work on this until you consider it ready-to-merge. I turned it back into draft, since I want to test this on a local instance tomorrow. Thanks for maintaining this anyway, it helped us built some nice stuff here, so consider that we owe you some dev time if asked 🙌 |
This PR is stale because it has been open for 30 days with no activity. |
As a data analyst, I would like to take advantage of the POST
/api/dashboard
method that allows me to create a dashboard with the name provided and the collection information needed to create it at the right place.