-
-
Notifications
You must be signed in to change notification settings - Fork 849
feat[lang]: add ABIBuffer type #4561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat[lang]: add ABIBuffer type #4561
Conversation
@@ -23,7 +23,7 @@ | |||
from vyper.semantics.analysis.levenshtein_utils import get_levenshtein_error_suggestions | |||
from vyper.semantics.namespace import get_namespace | |||
from vyper.semantics.types.base import TYPE_T, VyperType | |||
from vyper.semantics.types.bytestrings import BytesT, StringT | |||
from vyper.semantics.types.bytestrings import _BytestringT |
Check notice
Code scanning / CodeQL
Cyclic import Note
vyper.semantics.types.bytestrings
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4561 +/- ##
==========================================
- Coverage 92.70% 92.65% -0.06%
==========================================
Files 123 122 -1
Lines 17526 17565 +39
Branches 2971 2984 +13
==========================================
+ Hits 16248 16275 +27
- Misses 879 892 +13
+ Partials 399 398 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/add-abi-buffer-type Fork/charles cooper/feat/lang/add abi buffer type
@@ -31,6 +31,7 @@ | |||
) | |||
from vyper.semantics.data_locations import DataLocation | |||
from vyper.semantics.types.base import KwargSettings, VyperType | |||
from vyper.semantics.types.bytestrings import ReturnBufferT |
Check notice
Code scanning / CodeQL
Cyclic import Note
vyper.semantics.types.bytestrings
event FooEvent:
a: ReturnBuffer[100]
interface Foo:
def foo() -> ReturnBuffer[100]: view
@external
def foo(target: Foo):
log FooEvent(a=staticcall target.foo()) yields
i don't think that "not a valid tuple member" is a very clear ex |
…/add-abi-buffer-type add returndatasize test
note that the fact, that we don't allow conversion into the type doesn't support thus it's basically impossible to do post-processing on it |
What I did
bypasses abi encoding of return types
How I did it
How to verify it
check the following code
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture