fix[lang]: fix missing HexBytes paths #4630
Open
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe we should also fix this #4604 in the scope of this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4630 +/- ##
==========================================
+ Coverage 92.49% 92.50% +0.01%
==========================================
Files 128 128
Lines 18528 18529 +1
Branches 3213 3213
==========================================
+ Hits 17138 17141 +3
+ Misses 945 944 -1
+ Partials 445 444 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
commented
May 6, 2025
| ("0123456789abcdef", 0x0123456789ABCDEF), | ||
| ], | ||
| ) | ||
| def test_convert_bytes_literal_int(get_contract, val, expected): |
There was a problem hiding this comment.
we should probably add test cases which would trigger sign extension
| @@ -244,6 +244,9 @@ def _literal_decimal(expr, arg_typ, out_typ): | |||
| val = decimal.Decimal(int(expr.value, 16)) | |||
| else: | |||
| val = decimal.Decimal(expr.value) # should work for Int, Decimal | |||
| # decimal.Decimal() can't be constructed from bytes | |||
| # this assert guards against a potential constructor change | |||
| assert not isinstance(expr.value, bytes) | |||
There was a problem hiding this comment.
Suggested change
| assert not isinstance(expr.value, bytes) | |
| assert isinstance(expr.value, int) |
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "val,expected", |
There was a problem hiding this comment.
can we compute expected from val?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
HexBytes#4608How I did it
HexBytesto the type checksHow to verify it