fix[tool]: fix output bundle construction #4654
Open
+95
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes output bundle construction when there is a semantic error during compilation.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -25,7 +25,7 @@ | |||
| from vyper.utils import OrderedSet | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from vyper.semantics.analysis.base import ImportInfo, ModuleInfo | |||
| from vyper.semantics.analysis.base import ModuleInfo | |||
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
charles-cooper
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4654 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 131 131
Lines 18939 18928 -11
Branches 3289 3283 -6
=======================================
- Hits 17574 17565 -9
+ Misses 934 932 -2
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
reviewed
May 23, 2025
| ast_dict = { | ||
| "contract_name": str(compiler_data.contract_path), | ||
| "ast": ast_to_dict(compiler_data.vyper_module), | ||
| "imports": [ast_to_dict(ast) for ast in imported_modules], |
There was a problem hiding this comment.
this misses json interfaces, maybe let's leave a comment/raise an issue
There was a problem hiding this comment.
yea, i'll leave a comment.
|
math doesn't show up in import for import math
def foo():
d: decimal = math.sqrt(2.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes output bundle construction when there is a semantic error during compilation.
What I did
fix #4526
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture