Skip to content

feat[venom]: allow SCCP to run without removing allocas #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025

Conversation

charles-cooper
Copy link
Member

this allows us to run it before mem2var, and in the future, will allow us to keep allocas around longer for alias analysis.

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

this allows us to run it before mem2var, and in the future, will allow
us to keep allocas around longer for alias analysis.
@charles-cooper charles-cooper requested a review from harkal May 22, 2025 12:47
@charles-cooper charles-cooper marked this pull request as ready for review May 22, 2025 12:47
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (533682d) to head (d1974e3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4655   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files         131      131           
  Lines       18947    18953    +6     
  Branches     3289     3290    +1     
=======================================
+ Hits        17583    17589    +6     
  Misses        933      933           
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper marked this pull request as draft May 22, 2025 13:35
@charles-cooper
Copy link
Member Author

marking as draft since there is a slight bytecode regression

@charles-cooper charles-cooper marked this pull request as ready for review May 26, 2025 12:54
@charles-cooper charles-cooper enabled auto-merge (squash) May 26, 2025 12:55
@charles-cooper charles-cooper merged commit e53133e into vyperlang:master May 26, 2025
159 checks passed
@charles-cooper charles-cooper deleted the sccp-alloca branch May 26, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants