Skip to content

Editoral: Link to registry inclusion criteria definitions #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025

Conversation

mohamedamir
Copy link
Contributor

@mohamedamir mohamedamir commented May 13, 2025

Before this PR, the definitions were created but never linked it, which causes ReSpec warnings,


Preview | Diff

@mohamedamir mohamedamir requested a review from a team as a code owner May 13, 2025 09:41
@mohamedamir mohamedamir force-pushed the link-to-register-inclusion-criteria-definitions branch from ee78854 to ae3ddbd Compare May 13, 2025 09:45
@timcappalli
Copy link
Collaborator

I don't think this is necessary as term definitions don't typically link to where they're used. It should be the opposite (the table headings link down to the definitions).

@mohamedamir
Copy link
Contributor Author

mohamedamir commented May 13, 2025

I don't think this is necessary as term definitions don't typically link to where they're used. It should be the opposite (the table headings link down to the definitions).

@timcappalli
Yes, this was my understanding as well, but I got confused by the current state.
So should I do the opposite or remove the definition tags altogether?
As of today, they are throwing ReSpec warnings and I believe we should get this fixed before publishing the FWPD.

WDYT?

@timcappalli timcappalli added the agenda+ Add to the weekly agenda label May 13, 2025
@timcappalli
Copy link
Collaborator

@mohamedamir reversed them in 92da697

@mohamedamir
Copy link
Contributor Author

Thanks @timcappalli
This indeed makes more sense!

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, for consistency & clarity.

@wseltzer wseltzer changed the title Link to registery inclusion criteria definitions Link to registry inclusion criteria definitions May 14, 2025
@marcoscaceres marcoscaceres changed the title Link to registry inclusion criteria definitions Editoral: Link to registry inclusion criteria definitions May 28, 2025
@mohamedamir mohamedamir merged commit 16a9ead into main May 29, 2025
1 check passed
@mohamedamir mohamedamir deleted the link-to-register-inclusion-criteria-definitions branch May 29, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agenda+ Add to the weekly agenda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants