Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Move tooltip def to accname #135

Merged
merged 4 commits into from
Mar 16, 2022
Merged

* Move tooltip def to accname #135

merged 4 commits into from
Mar 16, 2022

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Jul 15, 2021

* Change node, attribute & element to ref DOM spec
@jnurthen jnurthen requested a review from marcoscaceres July 15, 2021 00:44
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of little suggestions... more generally, would it make sense to define this "in place" somewhere in the document (or give this it's own section)?

If we give it's own section, we can stipulate what attribute from each host language are "tooltip attributes" (i.e., title from HTML and maybe whatever attribute SVG uses).

@jnurthen jnurthen requested a review from accdc July 22, 2021 17:12
@accdc accdc marked this pull request as ready for review August 27, 2021 23:24
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments. Otherwise ok.

Reminder to open issues for 2 of @marcoscaceres comments that were deferred.

Fixes typo; there are three possible values, not two.

Co-authored-by: Carolyn MacLeod <[email protected]>
@MelSumner MelSumner mentioned this pull request Mar 16, 2022
2 tasks
@MelSumner MelSumner merged commit 12b1b47 into main Mar 16, 2022
github-actions bot added a commit that referenced this pull request Mar 16, 2022
SHA: 12b1b47
Reason: push, by @MelSumner

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants