Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'starts with' to web custom format prefix. #195

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Add 'starts with' to web custom format prefix. #195

merged 6 commits into from
Oct 24, 2023

Conversation

snianu
Copy link
Contributor

@snianu snianu commented Sep 19, 2023 •
edited by pr-preview bot
Loading

Closes #175 (comment)

For normative changes, the following tasks have been completed:

Implementation commitment:

Preview | Diff

@snianu snianu mentioned this pull request Sep 19, 2023
Merged
4 tasks
@snianu
Copy link
Contributor Author

snianu commented Sep 19, 2023

@evanstade PTAL? Thanks!

@snianu snianu mentioned this pull request Oct 12, 2023
Merged
4 tasks
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Oct 12, 2023
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 12, 2023
@snianu @chromium-wpt-export-bot
[Async Clipboard API] Add supports method to async clipboard API.
6396779 
In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
sanketj
sanketj approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@sanketj sanketj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

evanstade
evanstade reviewed Oct 18, 2023
View reviewed changes
Copy link

@evanstade evanstade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay --- I was OOO from the middle of last week.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@snianu
Copy link
Contributor Author

snianu commented Oct 20, 2023

@evanstade Addressed your comments. PTAL.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 20, 2023
@snianu @chromium-wpt-export-bot
[Async Clipboard API] Add supports method to async clipboard API.
dfe7169 
In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
evanstade
evanstade suggested changes Oct 21, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 23, 2023
@snianu @chromium-wpt-export-bot
[Async Clipboard API] Add supports method to async clipboard API.
51bb28b 
In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 24, 2023
@snianu @chromium-wpt-export-bot
[Async Clipboard API] Add supports method to async clipboard API.
b0b223a 
In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 24, 2023
@snianu @chromium-wpt-export-bot
[Async Clipboard API] Add supports method to async clipboard API.
eb0b546 
In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
@snianu
Copy link
Contributor Author

snianu commented Oct 24, 2023

@evanstade Addressed your comments. PTAL.

evanstade
evanstade suggested changes Oct 24, 2023
View reviewed changes
Copy link

@evanstade evanstade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

index.bs Outdated Show resolved Hide resolved
@snianu snianu merged commit ad65071 into main Oct 24, 2023
2 checks passed
@snianu snianu deleted the starts-with branch October 24, 2023 20:31
github-actions bot added a commit that referenced this pull request Oct 24, 2023
@snianu @github-actions
Add 'starts with' to web custom format prefix. (#195)
f6ed973 
SHA: ad65071
Reason: push, by snianu

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable pushed a commit to chromium/chromium that referenced this pull request Oct 24, 2023
@snianu
[Async Clipboard API] Add supports method to async clipboard API.
7f77018 
In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4865377
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Anupam Snigdha <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1214477}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 24, 2023
@snianu @chromium-wpt-export-bot
[Async Clipboard API] Add supports method to async clipboard API.
d86a5f7 
In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4865377
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Anupam Snigdha <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1214477}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 24, 2023
@snianu @chromium-wpt-export-bot
[Async Clipboard API] Add supports method to async clipboard API.
d1bd574 
In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4865377
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Anupam Snigdha <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1214477}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 7, 2023
@snianu @moz-wptsync-bot
Bug 1860922 [wpt PR 41993] - [Async Clipboard API] Add supports metho…
5e3350e 
…d to async clipboard API., a=testonly

Automatic update from web-platform-tests
[Async Clipboard API] Add supports method to async clipboard API.

In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4865377
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Anupam Snigdha <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1214477}

--

wpt-commits: d1bd5741a6ec790fbec6e6d69158178d26f65269
wpt-pr: 41993
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 7, 2023
@snianu @moz-wptsync-bot
Bug 1860922 [wpt PR 41993] - [Async Clipboard API] Add supports metho…
9633d6e 
…d to async clipboard API., a=testonly

Automatic update from web-platform-tests
[Async Clipboard API] Add supports method to async clipboard API.

In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4865377
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Anupam Snigdha <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1214477}

--

wpt-commits: d1bd5741a6ec790fbec6e6d69158178d26f65269
wpt-pr: 41993
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 8, 2023
@marco-c
Bug 1860922 [wpt PR 41993] - [Async Clipboard API] Add supports metho…
c7fba16 
…d to async clipboard API., a=testonly

Automatic update from web-platform-tests
[Async Clipboard API] Add supports method to async clipboard API.

In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4865377
Reviewed-by: Kent Tamura <tkentchromium.org>
Commit-Queue: Anupam Snigdha <snianumicrosoft.com>
Reviewed-by: Evan Stade <estadechromium.org>
Cr-Commit-Position: refs/heads/main{#1214477}

--

wpt-commits: d1bd5741a6ec790fbec6e6d69158178d26f65269
wpt-pr: 41993

UltraBlame original commit: 1603ba63e55624bd159b523ea1c7430df469e647
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 8, 2023
@marco-c
Bug 1860922 [wpt PR 41993] - [Async Clipboard API] Add supports metho…
9943c0c 
…d to async clipboard API., a=testonly

Automatic update from web-platform-tests
[Async Clipboard API] Add supports method to async clipboard API.

In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4865377
Reviewed-by: Kent Tamura <tkentchromium.org>
Commit-Queue: Anupam Snigdha <snianumicrosoft.com>
Reviewed-by: Evan Stade <estadechromium.org>
Cr-Commit-Position: refs/heads/main{#1214477}

--

wpt-commits: d1bd5741a6ec790fbec6e6d69158178d26f65269
wpt-pr: 41993

UltraBlame original commit: 1603ba63e55624bd159b523ea1c7430df469e647
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 8, 2023
@marco-c
Bug 1860922 [wpt PR 41993] - [Async Clipboard API] Add supports metho…
8e556be 
…d to async clipboard API., a=testonly

Automatic update from web-platform-tests
[Async Clipboard API] Add supports method to async clipboard API.

In this change we are adding a new static method `supports` to the
ClipboardItem interface to help web authors detect clipboard format
types that are supported by Chromium.
Github Issue: w3c/clipboard-apis#170
Spec: w3c/clipboard-apis#192
w3c/clipboard-apis#195
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/pjpN9Lwv5Tk/m/KrAZRbdwAQAJ?utm_medium=email&utm_source=footer&pli=1

Bug: 1483026, 1490635

Change-Id: Ief7c0786833548d2fb51215cefbc39e5930af875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4865377
Reviewed-by: Kent Tamura <tkentchromium.org>
Commit-Queue: Anupam Snigdha <snianumicrosoft.com>
Reviewed-by: Evan Stade <estadechromium.org>
Cr-Commit-Position: refs/heads/main{#1214477}

--

wpt-commits: d1bd5741a6ec790fbec6e6d69158178d26f65269
wpt-pr: 41993

UltraBlame original commit: 1603ba63e55624bd159b523ea1c7430df469e647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanstade evanstade evanstade requested changes

@sanketj sanketj sanketj approved these changes

Assignees

@sanketj sanketj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snianu @evanstade @sanketj