Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align-3][css-overflow-3] Content alignment on scroll containers extends scrollable area #4957 #10139

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

fantasai
Copy link
Collaborator

See #4957.

Review questions:

@fantasai fantasai requested review from frivoal and tabatkins March 25, 2024 22:54
@tabatkins
Copy link
Member

Should we collapse the concepts of "scroll origin position" and "initial scroll position" now that they coincide even in the presence of alignment? If so, which word should we use?

Yes, we should collapse. For the term, I forget whether we're actually adjust the scroll origin (so 0 is at the end, or whatever) or if we're just starting it out at a non-zero value. Which is the case, we should lean toward that term imo.

I think we can close the two issues

Is the baseline one answered? I don't see anything in the edits apparently addressing that, but maybe it falls out of them in a more general way.

Having the "The scrollable overflow area is the union of:" list before the definition of key terms like “scroll position” seems wrong. Should I pull it out into its own subsection? Where?

Can you just swap the sections? It's already practically the entire subsection anyway, I don't think dropping it into a further subsection would really help.

…extends scrollable area w3c#4957

It does not otherwise affect layout or scrolling mechanics.
@fantasai fantasai force-pushed the scroll-container-alignment branch from cf4096f to e7e39d0 Compare March 10, 2025 18:57
@fantasai
Copy link
Collaborator Author

fantasai commented Mar 10, 2025

Rebased.

Given the addition of scroll-initial-target, I think we need to distinguish the [=scroll origin position=] and the [=initial scroll position=].

@fantasai
Copy link
Collaborator Author

Split out the ordering question into #11895

I'm going to merge this now.

@fantasai fantasai merged commit fc18e62 into w3c:main Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants