Limit the timer resolution in non-isolated contexts #93

yoavweiss · 2020-09-15T13:56:56Z

Closes #89

We still need to discuss and see what X value would be reasonable here

npm1 · 2020-09-15T14:11:41Z

This makes sense but I think we want to move this to some algorithm which is called every time we want to get a timestamp, otherwise the current settings object does not make much sense.

yoavweiss · 2020-09-15T14:20:40Z

This makes sense but I think we want to move this to some algorithm which is called every time we want to get a timestamp, otherwise the current settings object does not make much sense.

Good call. That would indeed be nicer and more precise.

annevk · 2020-09-22T16:07:34Z

require-corp does not guarantee isolation by itself. You want cross-origin isolated...

yoavweiss · 2020-09-22T16:43:01Z

require-corp does not guarantee isolation by itself. You want cross-origin isolated...

Cool, thanks!

annevk · 2020-09-23T09:55:36Z

Thinking about this more you probably want cross-origin isolated capability here. So only if cross-origin isolated is delegated would a third party frame get true high-resolution timers.

cc @domenic @yutakahirano

domenic · 2020-09-23T14:27:15Z

Yes, we purposefully don't export "cross-origin isolated" since people should be using the capability.

yoavweiss · 2020-09-28T16:02:57Z

FYI - @mikewest @camillelamy @hemeryar

yoavweiss · 2020-09-29T14:09:13Z

Rebased the PR based on #97 and comments. Please take a look.

We still need to determine:

What would a good value for X be?
How can we publish this from a process perspective?
- Do we need to go back to PR/CR? Define this as L3? Define HR-Time as a Living Standard as part of Process 2020?
Do we need WPTs? If so, how can we actually test this?

yutakahirano · 2020-09-29T14:24:07Z

Could you use https://html.spec.whatwg.org/multipage/webappapis.html#concept-settings-object-cross-origin-isolated-capability instead of agent cluster's cross-origin isolated?

yoavweiss · 2020-09-29T14:49:59Z

Could you use https://html.spec.whatwg.org/multipage/webappapis.html#concept-settings-object-cross-origin-isolated-capability instead of agent cluster's cross-origin isolated?

Exactly what I was looking for. Thanks!!

index.html

yoavweiss · 2020-10-06T13:56:25Z

There are 2 issues we still need to discuss it seems:

The value of the limit in the non-isolated context case
Removing the limit in the isolated context case

Regarding (1), I would go with 100 microseconds, as it's a value that seems to satisfy the use-cases without being overly granular.

The use-cases I found for sub-millisecond timers are:

Ability to schedule work in sub-millisecond intervals
- When running work on the main thread developers have a "window" of a few ms to do all the work they need to do for the browser to properly generate the next frame. 1ms granularity makes it hard to schedule such work without causing jank.
RUM based benchmarking - getting accurate timing for e.g. User Timing can matter, depending on what you're measuring.
Benchmarking (one example) - that seems like a less critical example, as folks who want to benchmark specific browser operations can do so in isolated contexts
Framerate calculations and audio/animation coordination

Regarding (2), I'm not convinced that isolated contexts resolve the spy in the sandbox caching attacks.
Talking to Chrome security folks, Chrome will not remove the limitation, even if the spec says it's no longer mandatory.
And while it's true that SAB and threads expose better granularity in isolated contexts, thread scheduling could mitigate that if that turns out to be a problem in practice.

At the same time, it may make sense to relax it in spec, as e.g. it may not be an issue on non-Intel hardware, and implementation-defined limitations could apply the limit only where it makes sense from a security perspective.

@annevk - Would you be interested in joining a WG call to discuss the above?

annevk · 2020-10-06T15:10:03Z

I chatted with Tom Ritter and my understanding about Firefox was incorrect. Firefox also does clamping:

Cross-origin isolated: clamped to 20 microseconds, no jitter.
Normal: clamped to 1000 microseconds, jitter.
Reduced fingerprinting preference enabled: clamped to 100000 microseconds, jitter (in both cross-origin isolated and normal).

We can change cross-origin isolated to clamp to 5 microseconds, but indeed, we want to keep clamping there as well and I was mistaken above.

(I could attend a call, but I'm not sure that's still needed?)

This aligns our implementation with [1]. [1] w3c/hr-time#93 Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b BUG: 1180178 Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b

This aligns our implementation with w3c/hr-time#93 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ BUG: 1180178 Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b

This aligns our implementation with w3c/hr-time#93 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ BUG: 1180178 Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 Commit-Queue: Yoav Weiss <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Reviewed-by: Paul Lewis <[email protected]> Reviewed-by: Klaus Weidner <[email protected]> Cr-Commit-Position: refs/heads/master@{#865234}

This reverts commit a6bff86b7b59db2467b5b4fc2fd7a05c093f33a6. Reason for revert: Causing gamepad/gamepad-polling-access.html to fail (see https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/115719/overview) Original change's description: > Coarsen performance.now() in cross-origin non-isolated contexts > > This aligns our implementation with w3c/hr-time#93 > > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ > > BUG: 1180178 > Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 > Commit-Queue: Yoav Weiss <[email protected]> > Reviewed-by: Andrey Kosyakov <[email protected]> > Reviewed-by: Nicolás Peña Moreno <[email protected]> > Reviewed-by: Camille Lamy <[email protected]> > Reviewed-by: Paul Lewis <[email protected]> > Reviewed-by: Klaus Weidner <[email protected]> > Cr-Commit-Position: refs/heads/master@{#865234} Change-Id: If7d5a4318f3a1cf172675d418ece9c6d8001e5ba No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779717 Auto-Submit: Adithya Srinivasan <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/master@{#865303}

This reverts commit 8f63c9bfc76588ff57f1945a558cab7cf45ff79a. Reason for revert: Test should be marked as flaky Original change's description: > Revert "Coarsen performance.now() in cross-origin non-isolated contexts" > > This reverts commit a6bff86b7b59db2467b5b4fc2fd7a05c093f33a6. > > Reason for revert: Causing gamepad/gamepad-polling-access.html to fail (see https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/115719/overview) > > Original change's description: > > Coarsen performance.now() in cross-origin non-isolated contexts > > > > This aligns our implementation with w3c/hr-time#93 > > > > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ > > > > BUG: 1180178 > > Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 > > Commit-Queue: Yoav Weiss <[email protected]> > > Reviewed-by: Andrey Kosyakov <[email protected]> > > Reviewed-by: Nicolás Peña Moreno <[email protected]> > > Reviewed-by: Camille Lamy <[email protected]> > > Reviewed-by: Paul Lewis <[email protected]> > > Reviewed-by: Klaus Weidner <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#865234} > > Change-Id: If7d5a4318f3a1cf172675d418ece9c6d8001e5ba > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779717 > Auto-Submit: Adithya Srinivasan <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/master@{#865303} Change-Id: Idd11b301a00b2926e6cad6517e1ac7a14c68b376

This aligns our implementation with w3c/hr-time#93 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ BUG: 1180178 Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 Commit-Queue: Yoav Weiss <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Reviewed-by: Paul Lewis <[email protected]> Reviewed-by: Klaus Weidner <[email protected]> Cr-Commit-Position: refs/heads/master@{#865234}

This reverts commit a6bff86. Reason for revert: Causing gamepad/gamepad-polling-access.html to fail (see https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/115719/overview) Original change's description: > Coarsen performance.now() in cross-origin non-isolated contexts > > This aligns our implementation with w3c/hr-time#93 > > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ > > BUG: 1180178 > Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 > Commit-Queue: Yoav Weiss <[email protected]> > Reviewed-by: Andrey Kosyakov <[email protected]> > Reviewed-by: Nicolás Peña Moreno <[email protected]> > Reviewed-by: Camille Lamy <[email protected]> > Reviewed-by: Paul Lewis <[email protected]> > Reviewed-by: Klaus Weidner <[email protected]> > Cr-Commit-Position: refs/heads/master@{#865234} Change-Id: If7d5a4318f3a1cf172675d418ece9c6d8001e5ba No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779717 Auto-Submit: Adithya Srinivasan <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/master@{#865303}

This reverts commit 8f63c9bfc76588ff57f1945a558cab7cf45ff79a. Reason for revert: Test should be marked as flaky Original change's description: > Revert "Coarsen performance.now() in cross-origin non-isolated contexts" > > This reverts commit a6bff86b7b59db2467b5b4fc2fd7a05c093f33a6. > > Reason for revert: Causing gamepad/gamepad-polling-access.html to fail (see https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/115719/overview) > > Original change's description: > > Coarsen performance.now() in cross-origin non-isolated contexts > > > > This aligns our implementation with w3c/hr-time#93 > > > > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ > > > > BUG: 1180178 > > Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 > > Commit-Queue: Yoav Weiss <[email protected]> > > Reviewed-by: Andrey Kosyakov <[email protected]> > > Reviewed-by: Nicolás Peña Moreno <[email protected]> > > Reviewed-by: Camille Lamy <[email protected]> > > Reviewed-by: Paul Lewis <[email protected]> > > Reviewed-by: Klaus Weidner <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#865234} > > Change-Id: If7d5a4318f3a1cf172675d418ece9c6d8001e5ba > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779717 > Auto-Submit: Adithya Srinivasan <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/master@{#865303} Change-Id: Idd11b301a00b2926e6cad6517e1ac7a14c68b376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780473 Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#865593}

This reverts commit 8f63c9b. Reason for revert: Test should be marked as flaky Original change's description: > Revert "Coarsen performance.now() in cross-origin non-isolated contexts" > > This reverts commit a6bff86. > > Reason for revert: Causing gamepad/gamepad-polling-access.html to fail (see https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/115719/overview) > > Original change's description: > > Coarsen performance.now() in cross-origin non-isolated contexts > > > > This aligns our implementation with w3c/hr-time#93 > > > > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ > > > > BUG: 1180178 > > Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 > > Commit-Queue: Yoav Weiss <[email protected]> > > Reviewed-by: Andrey Kosyakov <[email protected]> > > Reviewed-by: Nicolás Peña Moreno <[email protected]> > > Reviewed-by: Camille Lamy <[email protected]> > > Reviewed-by: Paul Lewis <[email protected]> > > Reviewed-by: Klaus Weidner <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#865234} > > Change-Id: If7d5a4318f3a1cf172675d418ece9c6d8001e5ba > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779717 > Auto-Submit: Adithya Srinivasan <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/master@{#865303} Change-Id: Idd11b301a00b2926e6cad6517e1ac7a14c68b376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780473 Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#865593}

…n non-isolated contexts, a=testonly Automatic update from web-platform-tests Coarsen performance.now() in cross-origin non-isolated contexts This aligns our implementation with w3c/hr-time#93 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ BUG: 1180178 Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 Commit-Queue: Yoav Weiss <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Reviewed-by: Paul Lewis <[email protected]> Reviewed-by: Klaus Weidner <[email protected]> Cr-Commit-Position: refs/heads/master@{#865234} -- wpt-commits: 570d161c271531545c6481da73ca590c43de4f53 wpt-pr: 28069

…ss-origin non-isolated contexts", a=testonly Automatic update from web-platform-tests Revert "Coarsen performance.now() in cross-origin non-isolated contexts" This reverts commit a6bff86b7b59db2467b5b4fc2fd7a05c093f33a6. Reason for revert: Causing gamepad/gamepad-polling-access.html to fail (see https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/115719/overview) Original change's description: > Coarsen performance.now() in cross-origin non-isolated contexts > > This aligns our implementation with w3c/hr-time#93 > > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ > > BUG: 1180178 > Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 > Commit-Queue: Yoav Weiss <[email protected]> > Reviewed-by: Andrey Kosyakov <[email protected]> > Reviewed-by: Nicolás Peña Moreno <[email protected]> > Reviewed-by: Camille Lamy <[email protected]> > Reviewed-by: Paul Lewis <[email protected]> > Reviewed-by: Klaus Weidner <[email protected]> > Cr-Commit-Position: refs/heads/master@{#865234} Change-Id: If7d5a4318f3a1cf172675d418ece9c6d8001e5ba No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779717 Auto-Submit: Adithya Srinivasan <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/master@{#865303} -- wpt-commits: 136b02824b73ef9f0a2cff4142e4bfa9a1fa3b59 wpt-pr: 28176

…ss-origin non-isolated contexts", a=testonly Automatic update from web-platform-tests Reland "Coarsen performance.now() in cross-origin non-isolated contexts" This reverts commit 8f63c9bfc76588ff57f1945a558cab7cf45ff79a. Reason for revert: Test should be marked as flaky Original change's description: > Revert "Coarsen performance.now() in cross-origin non-isolated contexts" > > This reverts commit a6bff86b7b59db2467b5b4fc2fd7a05c093f33a6. > > Reason for revert: Causing gamepad/gamepad-polling-access.html to fail (see https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/115719/overview) > > Original change's description: > > Coarsen performance.now() in cross-origin non-isolated contexts > > > > This aligns our implementation with w3c/hr-time#93 > > > > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/k6M3HJiqmkE/m/zgaVyKfnAwAJ > > > > BUG: 1180178 > > Change-Id: Ie3e62ab03fdb4eef49f818145e03476a0747464b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757334 > > Commit-Queue: Yoav Weiss <[email protected]> > > Reviewed-by: Andrey Kosyakov <[email protected]> > > Reviewed-by: Nicolás Peña Moreno <[email protected]> > > Reviewed-by: Camille Lamy <[email protected]> > > Reviewed-by: Paul Lewis <[email protected]> > > Reviewed-by: Klaus Weidner <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#865234} > > Change-Id: If7d5a4318f3a1cf172675d418ece9c6d8001e5ba > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779717 > Auto-Submit: Adithya Srinivasan <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/master@{#865303} Change-Id: Idd11b301a00b2926e6cad6517e1ac7a14c68b376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780473 Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#865593} -- wpt-commits: 57747da202f050d84df2b73e5821a56b18af66f7 wpt-pr: 28178

yoavweiss requested a review from npm1 September 15, 2020 13:56

yoavweiss closed this Sep 15, 2020

yoavweiss reopened this Sep 15, 2020

yoavweiss added the hackathon_15_09_20 label Sep 15, 2020

yoavweiss mentioned this pull request Sep 21, 2020

Comments on "Define 'relative high resolution time'" #96

Closed

yoavweiss added 2 commits September 22, 2020 18:46

Limit the timer resolution in non-isolated contexts

c90c508

Fix link

acbe297

yoavweiss added 2 commits September 29, 2020 15:12

draft

b7c7ab7

Rebase based on w3c#97 and PR comments

464495f

yoavweiss force-pushed the limit_non_isolated branch from a4bbed4 to 464495f Compare September 29, 2020 14:04

Tidy up

a160db4

More precise references

9bfec3a

yoavweiss mentioned this pull request Sep 29, 2020

Can "cross-origin isolated" be exported? whatwg/html#5960

Closed

Highlight variables, as we now have longer algorithms here

bfc80f4

Use cross-origin isolated capability

ed36bab

annevk reviewed Sep 30, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

Review comments from Anne

5186376

yoavweiss mentioned this pull request Oct 6, 2020

Add sub-millisecond timer use-cases #101

Closed

yoavweiss mentioned this pull request Mar 17, 2021

Aligning high-resolution timer granularity to cross-origin isolated capability mozilla/standards-positions#502

Closed

chromium-wpt-export-bot mentioned this pull request Mar 22, 2021

Revert "Coarsen performance.now() in cross-origin non-isolated contexts" web-platform-tests/wpt#28176

Merged

chromium-wpt-export-bot mentioned this pull request Mar 22, 2021

Reland "Coarsen performance.now() in cross-origin non-isolated contexts" web-platform-tests/wpt#28178

Merged

yoavweiss mentioned this pull request Apr 15, 2021

cross origin timers post GoogleChrome/developer.chrome.com#644

Merged

nolanlawson mentioned this pull request Apr 25, 2022

Enable cross-origin isolation to improve timing precision google/tachometer#233

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Limit the timer resolution in non-isolated contexts #93

Limit the timer resolution in non-isolated contexts #93

yoavweiss commented Sep 15, 2020 •

edited by pr-preview bot

Loading

npm1 commented Sep 15, 2020

yoavweiss commented Sep 15, 2020

annevk commented Sep 22, 2020

yoavweiss commented Sep 22, 2020

annevk commented Sep 23, 2020

domenic commented Sep 23, 2020

yoavweiss commented Sep 28, 2020

yoavweiss commented Sep 29, 2020

yutakahirano commented Sep 29, 2020

yoavweiss commented Sep 29, 2020

yoavweiss commented Oct 6, 2020

annevk commented Oct 6, 2020 •

edited

Loading

Limit the timer resolution in non-isolated contexts #93

Limit the timer resolution in non-isolated contexts #93

Conversation

yoavweiss commented Sep 15, 2020 • edited by pr-preview bot Loading

npm1 commented Sep 15, 2020

yoavweiss commented Sep 15, 2020

annevk commented Sep 22, 2020

yoavweiss commented Sep 22, 2020

annevk commented Sep 23, 2020

domenic commented Sep 23, 2020

yoavweiss commented Sep 28, 2020

yoavweiss commented Sep 29, 2020

yutakahirano commented Sep 29, 2020

yoavweiss commented Sep 29, 2020

yoavweiss commented Oct 6, 2020

annevk commented Oct 6, 2020 • edited Loading

yoavweiss commented Sep 15, 2020 •

edited by pr-preview bot

Loading

annevk commented Oct 6, 2020 •

edited

Loading