Skip to content

Clarify that itts:forcedDisplay applies regardless of the computed value of tts:visibility #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

palemieux
Copy link
Contributor

@palemieux palemieux commented Feb 12, 2025

Closes #593

@palemieux palemieux changed the title Clarify that itts:forcedDisplay applies regardless of the computed va… Clarify that itts:forcedDisplay applies regardless of the computed value of tts:visibility Feb 12, 2025
@palemieux palemieux self-assigned this Feb 12, 2025
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as is, some suggestions added.

So that it is visible without scrolling, since it's the most important part of this example.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rearranged the attributes on the <region> so that the most important ones (for the example purpose) are earlier, because I found that otherwise I had to scroll horizontally to see itts:forcedDisplay.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@palemieux palemieux merged commit 360b6f4 into main Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

itts:forcedDisplay applies regardless of the computed value of tts:visibility
2 participants