Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various non-normative HTML fixes #146

Merged
merged 19 commits into from
Jan 11, 2024
Merged

Various non-normative HTML fixes #146

merged 19 commits into from
Jan 11, 2024

Conversation

dr-shorthair
Copy link
Collaborator

fixes #143

@dr-shorthair dr-shorthair changed the title Various non-normative HTML fixes addressing #143 Various non-normative HTML fixes Jan 4, 2024
@KathiSchleidt KathiSchleidt self-requested a review January 4, 2024 20:40
@dr-shorthair
Copy link
Collaborator Author

Could one more person review so this can be merged?

Copy link
Contributor

@ldesousa ldesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dr-shorthair This is a very large set of changes, since it is non-normative I didin't look into detail to the content, but a few points are worth considering:

  1. There are many "... TODO ..." notes across the document. Is it on purpose? Eve if yes consider instead to open an issue pointing to the missing content.

  2. It looks like some of the inner blue tables are missing cells (i.e. the background is not applied). Some examples below.

Selection_121
Selection_122

  1. There are many broken links throughout the document. In Brave (Chromium) the HTML render marks those with a red wavy underline. A few examples below.

Selection_126
Selection_125
Selection_124
Selection_123

sgrellet and others added 3 commits January 10, 2024 14:47
…'Error' from the report. I hope didn't break anything
2. add pointer to [Hide SSN axioms] etc
3. Fix broken internal links
Fix property name (a very old bug!)
@dr-shorthair
Copy link
Collaborator Author

Thank you @ldesousa

  1. The TODO comments are either
  1. The inner blue tables show the axioms in the SSN graph. If you click the link [Hide additional SSN axioms] it will be hidden. I've added a note in the Modularization section drawing attention to this capability
  2. I've fixed 7 broken links (internal cross-references). The red underlines associated with the show/hide buttons are an artefact of javascript and relative paths which should go away when the branch is merged.

I also accepted the lint corrections from @sgrellet

See https://raw.githack.com/w3c/sdw-sosa-ssn/fix-html/ssn/index.html#Specification for the revised state

@dr-shorthair dr-shorthair merged commit c509b7b into gh-pages Jan 11, 2024
1 check passed
@dr-shorthair dr-shorthair deleted the fix-html branch January 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format index.html source
4 participants