Base Proof Options on Data Integrity with Restrictions #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind4Greg
requested review from
msporny,
dlongley,
iherman,
dmitrizagidulin,
TallTed,
brianorwhatever and
brentzundel
dlongley
approved these changes
Jan 9, 2024
TallTed
approved these changes
Jan 9, 2024
Co-authored-by: Dave Longley <[email protected]>
msporny
approved these changes
Feb 2, 2024
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #108 to ensure that the
createdproof option is OPTIONAL. It does this by referring to the VC Data Integrity specification for all proof options and only mentioning proof options explicitly where their values are in some way restricted. This keeps this specification better align with VC Data Integrity as well as resolving the issue.💥 Error: 502 Bad Gateway 💥
PR Preview failed to build. (Last tried on Feb 2, 2024, 4:45 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.