Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY FOR REVIEW] Brazilian Portuguese - An alt Decision Tree #951

Conversation

adielcristo
Copy link
Contributor

@adielcristo adielcristo commented Nov 6, 2024

Direct link to preview

Translate resource pages/design-develop/tutorials/images/decision-tree.md to pt-BR

Resolves w3c/wai-translations#260

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for wai-website ready!

Name Link
🔨 Latest commit 6af23ab
🔍 Latest deploy log https://app.netlify.com/sites/wai-website/deploys/67b3698e57d752000872fe7b
😎 Deploy Preview https://deploy-preview-951--wai-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@adielcristo adielcristo changed the title Brazilian Portuguese - An alt Decision Tree [READY FOR REVIEW] Brazilian Portuguese - An alt Decision Tree Nov 6, 2024
@israelcefrin
Copy link

Hello @adielcristo and @remibetin, I’ll be reviewing this translation PR and plan to complete it by December 23rd, 2024.

@israelcefrin
Copy link

Hello @adielcristo , I haven't found any issue on the translation!
The only outstanding item is the missing page label on the navigation component at the bottom. It is not linked neither showing the page titles. But, I assume it is a system issue rather than a missing translation. Could you please double check that "Anterior" and. "Próxima" will be linking when going to production and showing the destination page title?

image

@adielcristo
Copy link
Contributor Author

Hello @adielcristo , I haven't found any issue on the translation! The only outstanding item is the missing page label on the navigation component at the bottom. It is not linked neither showing the page titles. But, I assume it is a system issue rather than a missing translation. Could you please double check that "Anterior" and. "Próxima" will be linking when going to production and showing the destination page title?

Hi @israelcefrin, based on the code in prevnext-navigation.html, it seems to be caused by the presence of the config translation, that points to non-existent files.

@remibetin Should we keep it while still not having the translations?

@remibetin remibetin self-requested a review February 17, 2025 16:45
@remibetin remibetin assigned remibetin and unassigned israelcefrin Feb 17, 2025
@remibetin
Copy link
Member

Thanks @adielcristo @israelcefrin, I am merging this PR and will publish the translation very soon.

The only outstanding item is the missing page label on the navigation component at the bottom. It is not linked neither showing the page titles. But, I assume it is a system issue rather than a missing translation. Could you please double check that "Anterior" and. "Próxima" will be linking when going to production and showing the destination page title?

@israelcefrin @adielcristo It is indeed a system issue. I have created a dedicated issue to track this issue and provide a solution: w3c/wai-website-theme#120

@remibetin remibetin merged commit a8876c5 into w3c:main Feb 17, 2025
4 checks passed
@adielcristo adielcristo deleted the feature/translate-tutorials-images-decision-tree branch February 18, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Brazilian Portuguese] An alt Decision Tree
3 participants