Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device public key extension #1663

Merged
merged 144 commits into from
Oct 7, 2022
Merged

Commits on Apr 16, 2021

  1. device-bound Public Key pair extension

    This PR instantiates the `getDevicePublicKey` extension.
    
    RPs desiring to have a guaranteed device-bound public key returned on `create()` and `get()` need to simply include this extension on their `create()` and `get()` calls.
    
    On `create()`, a device-bound public key pair is created in addition to the [credential key pair](https://www.w3.org/TR/webauthn-2/#credential-key-pair), and the extension result conveys the devicePublicKey to the RP.
    
    On `get()`, a device-bound public key pair is created if one does not yet exist, and the resulting devicePublicKey is conveyed in the extension result to the RP.
    equalsJeffH committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    6719e05 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. further hacking...

    equalsJeffH committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    4a6b8fe View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Configuration menu
    Copy the full SHA
    5d1662d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. add 'device-bound key'

    equalsJeffH committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    1622df2 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. in-progress updates...

    equalsJeffH committed May 6, 2021
    Configuration menu
    Copy the full SHA
    5e684aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71afdbe View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Configuration menu
    Copy the full SHA
    8040d13 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38131e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad71ff1 View commit details
    Browse the repository at this point in the history
  4. further edits...

    equalsJeffH committed May 7, 2021
    Configuration menu
    Copy the full SHA
    094d385 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e66eb2d View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Device-bound public key ProVerif model

    This adds a ProVerif model for the device-bound public key (device-bound key pair) extension.
    equalsJeffH committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    618b2de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e97952 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. editorial polishing

    equalsJeffH committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    8f0d66d View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. editorial polishing

    equalsJeffH committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    43e03c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Configuration menu
    Copy the full SHA
    503a027 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. further reorg & polish

    equalsJeffH committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    87340d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. proverif model cleanup

    equalsJeffH committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    cbb066f View commit details
    Browse the repository at this point in the history
  2. remove unused 'cert'

    equalsJeffH committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    1e72a00 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Configuration menu
    Copy the full SHA
    99a6b79 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. clarifications

    equalsJeffH committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e9db523 View commit details
    Browse the repository at this point in the history
  2. clarifications

    equalsJeffH committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    68ebaa2 View commit details
    Browse the repository at this point in the history
  3. clarifications

    equalsJeffH committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8b5702c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    da82c2e View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. clarifications

    equalsJeffH committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f84069b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6663cb View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. revise model significantly

    revise model to have discrete message components and to leverage named_tuples.pvl and crypto.pvl.
    equalsJeffH committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    22e325d View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. further clarifications and musings

    this is the stage of development I first shared with internal colleagues post the original hand-wavy prose writeup.
    equalsJeffH committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    a3ed05b View commit details
    Browse the repository at this point in the history
  2. editorial

    equalsJeffH committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    6382444 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. Configuration menu
    Copy the full SHA
    768d900 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Configuration menu
    Copy the full SHA
    fd9ea00 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Configuration menu
    Copy the full SHA
    a34b489 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Configuration menu
    Copy the full SHA
    2832b5e View commit details
    Browse the repository at this point in the history
  2. editorial

    equalsJeffH committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    e47c5f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75c8f25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4515d63 View commit details
    Browse the repository at this point in the history
  5. editorial

    equalsJeffH committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    c208e19 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    591cded View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    59260f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Configuration menu
    Copy the full SHA
    c3487a2 View commit details
    Browse the repository at this point in the history
  2. add README.pv.md file

    equalsJeffH committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    0e8d3b3 View commit details
    Browse the repository at this point in the history
  3. editorial cleanups

    equalsJeffH committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    6b216db View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2021

  1. Configuration menu
    Copy the full SHA
    25b07e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2da4504 View commit details
    Browse the repository at this point in the history
  3. editorial

    equalsJeffH committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    f943bbc View commit details
    Browse the repository at this point in the history
  4. attPublicKey is public

    equalsJeffH committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    e23ccfe View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Configuration menu
    Copy the full SHA
    7a1e2ee View commit details
    Browse the repository at this point in the history
  2. WIP: attObject parsing

    equalsJeffH committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    8a420eb View commit details
    Browse the repository at this point in the history
  3. WIP: add Extensions.

    equalsJeffH committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    d2b529b View commit details
    Browse the repository at this point in the history
  4. editorial

    equalsJeffH committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    666718a View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Configuration menu
    Copy the full SHA
    f9e861c View commit details
    Browse the repository at this point in the history
  2. refine events

    equalsJeffH committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e1a4383 View commit details
    Browse the repository at this point in the history
  3. editorial

    equalsJeffH committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    9182fa1 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. editorial

    equalsJeffH committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    89e2660 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Configuration menu
    Copy the full SHA
    54eb767 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. Configuration menu
    Copy the full SHA
    f6fcee8 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Configuration menu
    Copy the full SHA
    1747dff View commit details
    Browse the repository at this point in the history
  2. update README.pv.md

    equalsJeffH committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    12ec079 View commit details
    Browse the repository at this point in the history
  3. edit README.pv.md

    equalsJeffH committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    59f2909 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2021

  1. Configuration menu
    Copy the full SHA
    8b4d51c View commit details
    Browse the repository at this point in the history
  2. edit README.pv.md

    equalsJeffH committed Aug 15, 2021
    Configuration menu
    Copy the full SHA
    c5f3b2d View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Configuration menu
    Copy the full SHA
    4ebd028 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f18790 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66e67bd View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. work in progress

    equalsJeffH committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    9ac274a View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Configuration menu
    Copy the full SHA
    fcc6a68 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73cc7ff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c5393c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. context is now scope

    Co-authored-by: Emil Lundberg <[email protected]>
    equalsJeffH and emlun authored Nov 12, 2021
    Configuration menu
    Copy the full SHA
    3d16662 View commit details
    Browse the repository at this point in the history
  2. do binary equality checks

    equalsJeffH committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    aee534c View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from emlun's code review, thanks!

    Co-authored-by: Emil Lundberg <[email protected]>
    equalsJeffH and emlun authored Nov 12, 2021
    Configuration menu
    Copy the full SHA
    7c3e2e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    90593b9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d0bef33 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    89cec45 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. incorp pascoej's correction, thx!

    Co-authored-by: J Pascoe <[email protected]>
    equalsJeffH and pascoej authored Nov 15, 2021
    Configuration menu
    Copy the full SHA
    db63d69 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    9a78683 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Apply emlun's suggestions, thx!

    Co-authored-by: Emil Lundberg <[email protected]>
    equalsJeffH and emlun authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    d52342c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e23c4b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Configuration menu
    Copy the full SHA
    b8ec5b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bb9aaa View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. minor editorial fixes

    equalsJeffH committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3237896 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Configuration menu
    Copy the full SHA
    d652787 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55e64c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    41ffcbf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f131d68 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e1e6d94 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Configuration menu
    Copy the full SHA
    23ea3ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    683ad4d View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Configuration menu
    Copy the full SHA
    17f3aa2 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. clarification

    equalsJeffH committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    b4e8d0e View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. wordsmithing, thx emlun!

    equalsJeffH committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    619ebb9 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Configuration menu
    Copy the full SHA
    2730294 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2022

  1. Configuration menu
    Copy the full SHA
    f0fe8f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Configuration menu
    Copy the full SHA
    f145234 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8d8567 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. The DPK is stored on the authenticator.

    The text said that the DPK was stored on the client device, but the
    client device is the device that the browser is running on, not the
    authenticator. That _might_ be the same device, but it's unclear.
    Clarify that the DPKs come from the authenticator.
    agl committed May 19, 2022
    Configuration menu
    Copy the full SHA
    d92bad2 View commit details
    Browse the repository at this point in the history
  2. Provide attestation controls.

    Mirror the attestation controls for user credentials into the DPK
    extension.
    agl committed May 19, 2022
    Configuration menu
    Copy the full SHA
    6d45aba View commit details
    Browse the repository at this point in the history
  3. Pull out DPK attestation rules and add signature prefix.

    This change adds a section about calculating DPK attestations and
    references that each time rather than duplicating the rules. It also
    adds a prefix to the signed messages to ensure that DPK and user
    credential attestations clearly cannot be confused.
    agl committed May 19, 2022
    Configuration menu
    Copy the full SHA
    eb598ff View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b7289e1 View commit details
    Browse the repository at this point in the history
  5. Have the DPK sign over everything.

    Signing over too little is a common problem in protocols and the DPK
    wasn't signing over very much. The problem is that the signature was
    within the extension itself and thus couldn't easily cover the
    authenticator data.
    
    This change puts the DPK signature next to the normal signature in an
    assertion, transforming that field into a CBOR array. That's fine for
    assertions, but registration doesn't have such a signature output. Thus
    this change drops exercising the DPK during registration:
    
    Firstly, this is in line with the user credential which doesn't sign
    during registration unless "self" attestation is used. (And "self"
    attestation can be use with the DPK if desired.)
    
    Secondly, adding an extra signature output for registration is awkward.
    Putting it in the user credential attestation statement is awkward and
    conflicts when user-agents replace attestation statements. Adding a new
    CTAP field is possible but seems excessive since, as noted, there has
    never been a signature by the user credential.
    agl committed May 19, 2022
    Configuration menu
    Copy the full SHA
    dcfb392 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cbb6b5d View commit details
    Browse the repository at this point in the history
  7. Resolve comment by jovasco

    agl committed May 19, 2022
    Configuration menu
    Copy the full SHA
    ccfd0b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Merge branch 'main' into dpk

    agl committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    f3315b5 View commit details
    Browse the repository at this point in the history
  2. Link definitions from PR 1695.

    agl committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    27ef223 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bfce0cf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20dd35c View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Configuration menu
    Copy the full SHA
    27d0895 View commit details
    Browse the repository at this point in the history
  2. Fix build error

    arnar committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    e30cdb1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    38fb4e1 View commit details
    Browse the repository at this point in the history
  4. Fix misplaced Note annotation

    arnar committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    0c7fad0 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1754 from arnar/jeffh-fix-1658-device-bound-key-e…

    …xtension
    
    Introduce unsigned extension outputs in DPK PR
    agl authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    844cff7 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Configuration menu
    Copy the full SHA
    6fbfccf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e67faa View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Configuration menu
    Copy the full SHA
    832c2e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2022

  1. Merge pull request #1787 from w3c/merge-main-into-1658

    Fix merge conflicts in PR #1658
    agl authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    6940a43 View commit details
    Browse the repository at this point in the history
  2. Apply more of emlun's suggestions from code review

    (GitHub is struggling with the number of them, thus I'm trying to do just the first half.)
    
    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    7b531a8 View commit details
    Browse the repository at this point in the history
  3. Apply one of emlun's suggestions

    (This one seems to break GitHub's UI.)
    
    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    04ddb48 View commit details
    Browse the repository at this point in the history
  4. Apply one of emlun's suggestions

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    3cba94c View commit details
    Browse the repository at this point in the history
  5. Apply one of emlun's suggestions

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    47017e4 View commit details
    Browse the repository at this point in the history
  6. Apply one of emlun's suggestions

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    16a846a View commit details
    Browse the repository at this point in the history
  7. Apply one of emlun's suggestions

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    2ec8861 View commit details
    Browse the repository at this point in the history
  8. Apply suggestions from code review

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    5c1cd98 View commit details
    Browse the repository at this point in the history
  9. Apply suggestions from code review

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    5c6c23d View commit details
    Browse the repository at this point in the history
  10. Apply one of emlun's suggestions

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    a026a5b View commit details
    Browse the repository at this point in the history
  11. Have the authenticator output a bytestring, not a map.

    The platform generally echos the authenticator extension outputs in its
    own extension output and DPK does the same. In order to avoid either
    replicating the DPK output structure into IDL, or having the platforms
    re-encode it, have the authenticators produce a byte string containing
    the encoded map. The platform can then copy the byte string verbatim.
    agl committed Aug 20, 2022
    Configuration menu
    Copy the full SHA
    ec03d4d View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Configuration menu
    Copy the full SHA
    88be1a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    3430c95 View commit details
    Browse the repository at this point in the history
  2. RPs shouldn't check DPK attestation for equality.

    Otherwise they'll consider fresh attestations to be different devices.
    The attestation for existing DPKs is already checked in the “exactly one
    match” case.
    agl committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5af393d View commit details
    Browse the repository at this point in the history
  3. Remove incorrect note about nonces.

    Just because the attestation is changing doesn't mean that the
    authenticator is using a nonce. It could just be signing the same
    message repeatedly.
    agl committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    fe333fe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ece61f0 View commit details
    Browse the repository at this point in the history
  5. Apply one of emlun's suggestions

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Aug 25, 2022
    Configuration menu
    Copy the full SHA
    4279e6e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d25fd53 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Apply emlun's suggestions from code review

    Co-authored-by: Emil Lundberg <[email protected]>
    agl and emlun authored Sep 10, 2022
    Configuration menu
    Copy the full SHA
    8966fe6 View commit details
    Browse the repository at this point in the history
  2. Address emlun's comments.

    agl committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    d671894 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Configuration menu
    Copy the full SHA
    ca1b0c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6112877 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ed0b779 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Apply Shane's suggestions

    Co-authored-by: Shane Weeden <[email protected]>
    agl and sbweeden authored Sep 27, 2022
    Configuration menu
    Copy the full SHA
    9bd0e3d View commit details
    Browse the repository at this point in the history
  2. DPK is only valid for backup eligible credentials.

    (This was discussed at TPAC.
    agl committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    759ce04 View commit details
    Browse the repository at this point in the history
  3. Address Shane's comments.

    agl committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    8aa160c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. s/then/than, noticed by Shane.

    agl committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    bff403d View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Configuration menu
    Copy the full SHA
    fba2725 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Resolve last comment.

    This resolves https://github.com/w3c/webauthn/pull/1663/files#r790893167
    but including the suggested wording. (Tweaked to make bikeshed happy.)
    agl committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    f780870 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into dpk

    agl committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    6ae32a0 View commit details
    Browse the repository at this point in the history