Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP23: Wallet Interaction Standard #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndreasGassmann
Copy link

This PR adds a draft for the wallet interaction standard.

@AndreasGassmann AndreasGassmann changed the title Create psp-23.md PSP23: Wallet Interaction Standard Oct 27, 2021
@@ -0,0 +1,517 @@
# Wallet Interaction Standard

- **PSP Number:** 23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The psp number should be 29. Could you update this? Once this is done. I would be happy to merge this as an initial draft to hopefully also kickstart a discussion.

@lamafab
Copy link
Contributor

lamafab commented Feb 18, 2022

@AndreasGassmann Hi, sorry for the delayed response. I went through the document and have some initial thoughts (good document, overall):

  • Shouldn’t id be an integer rather than a string?
  • I think MessageType should be separated into two types: one for requests and one for responses (which results in changes to BaseMessage, respectively).
    • While most of the variants are self explanatory, a short description would be nice, for example what ”broadcast_request” means exactly.
  • Interfaces that extend BaseMessage should probably not list fields like type, version, id and senderId again (I might be interpreting this wrongly, I haven't interacted with TypeScript that much).
  • Consider putting network into BaseMessage?
    • Any interfaces that extend BaseMessage should therefore remove the network field.
  • NetworkType is unspecified.
  • If Network.rpcUrl is passed on, maybe mentioned that it must comply with some sort of standard?
  • PermissionScope is missing ”broadcast_request”.

@lamafab lamafab added the awaiting-changes Waiting for upstream changes label Mar 18, 2022
@@ -0,0 +1,517 @@
# Wallet Interaction Standard

- **PSP Number:** 23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **PSP Number:** 23
- **PSP Number:** 29

Copy link
Contributor

@takahser takahser Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes Waiting for upstream changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants