Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring BaseInternaLinkBlock #46

Merged
merged 3 commits into from
Mar 11, 2025
+2 −6
Merged

Refactoring BaseInternaLinkBlock #46

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dccaf73
Replace BILB with ILB.
vossisboss Mar 4, 2025
7300e55
Removed old ILB.
vossisboss Mar 4, 2025
c64efce
Clean up unused abstract = True in InternalLinkBlock
laymonage Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions project_name/utils/blocks.py
View file
Original file line number Diff line number Diff line change
@@ -42,23 +42,19 @@ class Meta:
template = "components/streamfield/blocks/image_block.html"


class BaseInternalLinkBlock(blocks.StructBlock):
class InternalLinkBlock(blocks.StructBlock):
page = blocks.PageChooserBlock()
title = blocks.CharBlock(
required=False,
help_text="Leave blank to use page's listing title.",
)

class Meta:
abstract = True
icon = "link"
value_class = LinkStructValue


class InternalLinkBlock(BaseInternalLinkBlock):
pass

class ArticlePageLinkBlock(BaseInternalLinkBlock):
class ArticlePageLinkBlock(InternalLinkBlock):
page = blocks.PageChooserBlock(
page_type="news.ArticlePage",
)