Skip to content

Commit

Permalink
workflows/libvirt: add e2e job to test with CRI-O
Browse files Browse the repository at this point in the history
Added a new container_runtime matrix column to generate
one job for each runtime: containerd and crio.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
  • Loading branch information
wainersm committed Nov 25, 2024
1 parent 7edea5e commit 65bbaa4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/e2e_libvirt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ on:
description: SecureComms configuration. Defaults to none.
required: false
type: string
container_runtime:
default: 'containerd'
description: Name of the container runtime. Either containerd or crio.
required: false
type: string

env:
CLOUD_PROVIDER: libvirt
DEBIAN_FRONTEND: noninteractive
Expand Down Expand Up @@ -93,6 +99,7 @@ jobs:
export TEST_E2E_SECURE_COMMS="${{ inputs.secure_comms }}"
./libvirt/config_libvirt.sh
echo "CAA_IMAGE=\"${{ inputs.caa_image }}\"" >> libvirt.properties
echo "container_runtime=\"${{ inputs.container_runtime }}\"" >> libvirt.properties
# For debugging
cat libvirt.properties
Expand Down Expand Up @@ -123,6 +130,7 @@ jobs:
REGISTRY_CREDENTIAL_ENCODED: ${{ secrets.REGISTRY_CREDENTIAL_ENCODED }}
run: |
export CLOUD_PROVIDER=libvirt
export CONTAINER_RUNTIME="${{ inputs.container_runtime }}"
export DEPLOY_KBS=true
export TEST_PROVISION="yes"
export TEST_TEARDOWN="no"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/e2e_run_all.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ jobs:
uses: ./.github/workflows/e2e_libvirt.yaml
with:
caa_image: ${{ inputs.registry }}/cloud-api-adaptor:${{ inputs.caa_image_tag }}-dev
container_runtime: ${{ matrix.container_runtime }}
podvm_image: ${{ inputs.registry }}/podvm-${{ matrix.provider }}-${{ matrix.os }}-${{ matrix.arch }}:${{ inputs.podvm_image_tag }}
install_directory_artifact: install_directory
git_ref: ${{ inputs.git_ref }}
Expand Down
1 change: 1 addition & 0 deletions src/cloud-api-adaptor/libvirt/e2e_matrix_libvirt.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"container_runtime": ["containerd", "crio"],
"secure_comms": ["none"],
"os": ["ubuntu"],
"provider": ["generic"],
Expand Down

0 comments on commit 65bbaa4

Please sign in to comment.