Only email auth #13
Merged
Only email auth #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 9, 2023 15:36
The configuration setup for TypeOrmModule and GraphqlModule has been refactored for improved readability and maintenance. This mainly involves moving some config definitions into separate functions. Additionally, the bootstrap process in the main.ts file has been broken down into separate functions for better error handling and readability.
…actored for better code clarity.
Refactor ValidationException and add test files For the detailed explanation: Reorganized the ValidationException message creation by splitting it into smaller, more manageable functions. New tests have been written for GraphqlComplexityLimitException and ValidationException classes to verify their instantiation and error handling characteristics.
added 27 commits
December 11, 2023 03:51
Added a new decorator 'ClientIp' to get Client IP from the request context. This enhances security and access control in the app. Concurrently, unnecessary assertions were removed from 'AuthConfigService' tests, streamlining the testing process.
Modified 'getOrCreateUserByEmail' method in users.service.ts to not always create a new user, instead it first checks if a user with the given email address already exists. Added 'createUserByEmail' and 'createUser' methods for better functionality. Updated corresponding tests in users.service.spec.ts to reflect these changes.
The commit removes the entire verification-codes module from the project, including services, decorators, entities, and test files. These changes possibly indicate a refactor or restructuring of the way the project handles verification codes or it might imply that this functionality has been moved elsewhere in the codebase.
The commit involves the removal of several code files related to email authorization, verification codes, login attempts. This includes guards, strategies, DTOs, entities, services, and testing modules related to email authentication and login attempts. These actions suggest a significant refactor or change in the approach to managing authorization and login attempts.
…ervice' to limit the number of email verification sending attempts on the application. This is achieved using both the service and test suites for accurately tracking and enforcing such limits. In addition, the configurations were updated to separate max sending and input attempts for email verification codes, enabling more granular control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.