Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Partial version bumps for v0.34.0-rc.1 #3172

Merged
merged 4 commits into from
Nov 10, 2024
Merged

chore: Partial version bumps for v0.34.0-rc.1 #3172

merged 4 commits into from
Nov 10, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter commented Nov 8, 2024 •
edited
Loading

Description

Due to the issues arose in #3096
We decided to make a partial version bumping of vendor libs for v0.34.0-rc1.

Changes

  • nim-chronicles
  • nim-eth
  • nim-http-utils
  • nim-json-rpc
  • nim-json-serialization
  • nim-libp2p - tp ver 1.7.1
  • nim-metrics
  • nim-nat-traversal
  • nim-presto
  • nim-secp256k1
  • nim-serialization
  • nim-stew
  • nim-taskpools
  • nim-testutils
  • nim-toml-serialization
  • nim-unicodedb
  • nim-unittest2
  • nim-web3
  • nim-websock
  • nim-zlib
  • nimcrypto

Due to the huge refactorings in nim-web3 and nim-eth modules:
Code changes:

  • waku/node/waku_node.nim
  • make import explicit in waku tests to avoid add new - yet unused - libp2p deps: quick and ngtcp2

Issue

#3087

@NagyZoltanPeter NagyZoltanPeter self-assigned this Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3172

Built from c26fd4e

@NagyZoltanPeter NagyZoltanPeter marked this pull request as ready for review November 8, 2024 11:49
gabrielmer
gabrielmer approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Ivansete-status
Ivansete-status approved these changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

@NagyZoltanPeter NagyZoltanPeter merged commit 8368ff0 into master Nov 10, 2024
12 of 13 checks passed
@NagyZoltanPeter NagyZoltanPeter deleted the partial-bump-dependencies-for-v0.34.rc1 branch November 10, 2024 08:27
NagyZoltanPeter added a commit that referenced this pull request Nov 10, 2024
@NagyZoltanPeter
chore: Partial version bumps for v0.34.0-rc.1 (#3172)
e3b84e3 
* Bumps for v0.34.0-rc.1 - partial bumping - libp2p
* Avoid importing quic and ngtcp2 dependencies through tests
* libp2p 1.7.1, fixes RendezVous construction
@NagyZoltanPeter NagyZoltanPeter mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmer gabrielmer gabrielmer approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NagyZoltanPeter @gabrielmer @Ivansete-status