Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAKU2-Peer-Exchange: Remove #46

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Update WAKU2-Peer-Exchange: Remove #46

merged 5 commits into from
Jan 17, 2025

Conversation

jimstir
Copy link
Collaborator

@jimstir jimstir commented Dec 3, 2024

Remove WAKU2-Peer-Exchange from this repository as it has been moved to the rfc-index, located here https://github.com/vacp2p/rfc-index/blob/main/waku/standards/core/34/peer-exchange.md.

@jimstir jimstir requested a review from jm-clius January 2, 2025 15:36
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor comment, but can merge after that is addressed.

README.md Show resolved Hide resolved
@jimstir jimstir requested a review from jm-clius January 16, 2025 16:13
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For non-blocking comments (i.e. where I've approved in principle, but requested some minor changes) feel free to merge once those comments are resolved. If more extensive feedback/changes are required I will usually "Request Changes" or comment without approving. :)

@jimstir jimstir merged commit b0b37c0 into master Jan 17, 2025
0 of 2 checks passed
@jimstir jimstir deleted the peer-exchange-update branch January 17, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants